-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7348] - Only unassign linodes in the 'Linodes to be Unassigned from Subnet' list for Subnet Unassign Drawer #9851
fix: [M3-7348] - Only unassign linodes in the 'Linodes to be Unassigned from Subnet' list for Subnet Unassign Drawer #9851
Conversation
packages/manager/.changeset/pr-9851-upcoming-features-1698695391804.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
"Unassign Linodes" button is disabled when the unassign list is empty ✅
packages/manager/.changeset/pr-9851-upcoming-features-1698695391804.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, confirmed that only Linodes in the list get unassigned and that the unassign button is disabled if there are no Linodes in the list! 🔍
Description 📝
Saw this little bug when looking into Cassie's pr #9818 and thought I'd just put up a quick fix for it. Will create a ticket + add it to this PR's header once I'm done writing this pr
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
unassign-bug.mov
fixed-unassign-bug.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply