Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7348] - Only unassign linodes in the 'Linodes to be Unassigned from Subnet' list for Subnet Unassign Drawer #9851

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Oct 30, 2023

Description 📝

Saw this little bug when looking into Cassie's pr #9818 and thought I'd just put up a quick fix for it. Will create a ticket + add it to this PR's header once I'm done writing this pr

Changes 🔄

List any change relevant to the reviewer.

  • When removing linodes from our 'Linodes to unassign' list, make sure their configs also get removed so that we don't accidentally still unassign them

Preview 📷

Before After
unassign-bug.mov
fixed-unassign-bug.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • Using the dev env and with vpc flags
  • OR with vpc flags on the prod account (this should be working now, though it wasn't for me)

Reproduction steps

(How to reproduce the issue, if applicable)

  • Make sure you have 1+ linodes already assigned to a VPC
  • Click on the Subnets Unassign Drawer (do not use the inline unassign subnet link)
  • Select the linode(s) to unassign, then remove them from the list
  • Click the Unassign button
  • Note how these linodes are still unassigned, even though we removed them from the list

Verification steps

(How to verify changes)

  • Repeat the above behavior + confirm that only the linodes you actually want to unassign (the ones in the list) get unassigned
  • If there are no linodes in the list, the unassign button should be disabled

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai added the VPC Relating to VPC project label Oct 30, 2023
@coliu-akamai coliu-akamai self-assigned this Oct 30, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review October 30, 2023 19:50
@coliu-akamai coliu-akamai requested a review from a team as a code owner October 30, 2023 19:50
@coliu-akamai coliu-akamai requested review from hana-akamai, carrillo-erik and dwiley-akamai and removed request for a team October 30, 2023 19:50
@coliu-akamai coliu-akamai changed the title Subnet unassign drawer unassigns linodes it shouldn't be fix: [M3-7348] - Only unassign linodes in the 'Linodes to be Unassigned from Subnet' list for Subnet Unassign Drawer Oct 30, 2023
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

"Unassign Linodes" button is disabled when the unassign list is empty ✅

@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Oct 31, 2023
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, confirmed that only Linodes in the list get unassigned and that the unassign button is disabled if there are no Linodes in the list! 🔍

@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 31, 2023
@coliu-akamai coliu-akamai merged commit 65c9744 into linode:develop Oct 31, 2023
11 checks passed
@coliu-akamai coliu-akamai deleted the fix-subnet-unassign-bug branch November 6, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants