-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [UIE-6977] - Remove sort on region column on DBaaS landing page #9861
fix: [UIE-6977] - Remove sort on region column on DBaaS landing page #9861
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - @corya-akamai I assume you'll keep track of re-adding this later on. A TODO may help.
Added a changeset 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Confirmed region column no longer sortable. 🎉
+1 to Alban's suggestion for a // TODO ....
comment!
e5ef2c1
to
57b4683
Compare
|
Is the plan to hotfix this? Include in our next release (11/13/2023)? What's the status of the API fix, if any? |
It can go in the next release 11/13/2023. There's not ETA on API yet. DBaaS team is going to discuss with Carissa on the fix. |
Thank you! @corya-akamai |
Description 📝
Temporarily remove sorting on "Region" column due to API error 400 Bad request. Once the backend is fixed we can add back sorting on "Region" column. All other columns can be sorted without API error.
Changes 🔄
List any change relevant to the reviewer.
How to test 🧪
Reproduction steps
and remove "databases-order" from sort keys
Verification steps
As an Author I have considered 🤔
Check all that apply