Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UIE-6977] - Remove sort on region column on DBaaS landing page #9861

Conversation

corya-akamai
Copy link
Contributor

Description 📝

Temporarily remove sorting on "Region" column due to API error 400 Bad request. Once the backend is fixed we can add back sorting on "Region" column. All other columns can be sorted without API error.

Changes 🔄

List any change relevant to the reviewer.

  • Change TableSortCell to TableCell on Region column

How to test 🧪

Reproduction steps

Verification steps

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@corya-akamai corya-akamai requested a review from a team as a code owner November 1, 2023 15:25
@corya-akamai corya-akamai requested review from abailly-akamai and coliu-akamai and removed request for a team November 1, 2023 15:25
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - @corya-akamai I assume you'll keep track of re-adding this later on. A TODO may help.

Added a changeset 👍

@abailly-akamai abailly-akamai changed the title fix [UIE-6977]: Remove sort on region column on DBaaS landing page fix: [UIE-6977] - Remove sort on region column on DBaaS landing page Nov 2, 2023
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Confirmed region column no longer sortable. 🎉

+1 to Alban's suggestion for a // TODO .... comment!

@corya-akamai corya-akamai force-pushed the feature/UIE-6977-dbaas-landing-remove-region-sort branch from e5ef2c1 to 57b4683 Compare November 2, 2023 17:54
@corya-akamai
Copy link
Contributor Author

Looks good - @corya-akamai I assume you'll keep track of re-adding this later on. A TODO may help.
Added a TODO

@bnussman-akamai
Copy link
Member

bnussman-akamai commented Nov 2, 2023

Is the plan to hotfix this? Include in our next release (11/13/2023)? What's the status of the API fix, if any?

@corya-akamai
Copy link
Contributor Author

Is the plan to hotfix this? Include in our next release (11/13/2023)? What's the status of the API fix, if any?

It can go in the next release 11/13/2023. There's not ETA on API yet. DBaaS team is going to discuss with Carissa on the fix.

@bnussman-akamai
Copy link
Member

Thank you! @corya-akamai

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Nov 3, 2023
@abailly-akamai abailly-akamai merged commit a549b51 into linode:develop Nov 7, 2023
11 checks passed
@corya-akamai corya-akamai deleted the feature/UIE-6977-dbaas-landing-remove-region-sort branch July 31, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants