Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: NodeBalancer Config Node - Remove one-off-styled Chip #9883

Merged

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Nov 7, 2023

Description 📝

Now that our Chip component support the color prop, we can remove some one-off styling 🎉

Changes 🔄

  • Removes one-off styled Chip in favor of using Chip directly with the color prop
  • Adds mocks to help you test this PR

Preview 📷

Before After
Screenshot 2023-11-07 at 3 10 30 PM Screenshot 2023-11-07 at 3 08 05 PM
Screenshot 2023-11-07 at 3 10 20 PM Screenshot 2023-11-07 at 3 07 55 PM

How to test 🧪

Prerequisites

  • Run yarn in the repo root to make sure decencies are up to date (I updated the MSW recently)
  • Start your dev server (yarn dev)
  • Turn on the MSW

Verification steps

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added UX/UI Changes for UI/UX to review Clean Up labels Nov 7, 2023
@bnussman-akamai bnussman-akamai self-assigned this Nov 7, 2023
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner November 7, 2023 20:18
@bnussman-akamai bnussman-akamai requested review from cpathipa and cliu-akamai and removed request for a team November 7, 2023 20:18
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! looks good, confirmed chip colors ✅

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean up. confirmed chip styles.

@bnussman-akamai bnussman-akamai merged commit 84cb2f5 into linode:develop Nov 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Up UX/UI Changes for UI/UX to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants