fix: Account for region ID query param in Cypress clone test #9890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
cpathipa and
cliu-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Nov 9, 2023
|
(Not sure if we need a changeset for this since it supplements the work done in #9888 which hasn't been released yet and which does contain a changeset -- happy to add one if the team has other thoughts, however!) |
jaalah-akamai
approved these changes
Nov 9, 2023
jaalah-akamai
added
Approved
|
Merging despite failing tests -- only failed test is Longview, which is unrelated to this PR |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This fixes a Cypress test failure where the test expects the
regionIDquery parameter not to exist in certain circumstances. This inconsistency was fixed by #9888 but this PR updates the tests.Changes 🔄
How to test 🧪
We can use the automated tests for this.