Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Upgrade from Cypress 13.4.0 to Cypress 13.5.0 #9892

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

Upgrades from Cypress 13.4.0 to 13.5.0.

Normally wouldn't update so quickly since we just upgraded to 13.x, but 13.5.0 includes a lot of bugfixes, and I realized I never updated our Dockerfile when we upgraded to 13.4.0 so wanted to take the opportunity to take care of that too.

(This means that at the moment, our GHA tests are using Cypress 13.x, but our Jenkins tests are still using 12.)

Changes 🔄

List any change relevant to the reviewer.

  • Upgrades Cypress from 13.4.0 to 13.5.0
  • Updates our Dockerfile for Cypress 13.5.0

How to test 🧪

We can rely on the automated tests for this, but they can be run locally with yarn cy:run.

@jdamore-linode jdamore-linode self-assigned this Nov 9, 2023
@jdamore-linode jdamore-linode requested a review from a team as a code owner November 9, 2023 17:06
@jdamore-linode jdamore-linode requested review from jaalah-akamai and tyler-akamai and removed request for a team November 9, 2023 17:06
@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Nov 13, 2023
@tyler-akamai
Copy link
Contributor

LGTM 🚀

@jdamore-linode
Copy link
Contributor Author

Merging despite test failure -- failed test is unrelated to this PR and is fixed in develop

@jdamore-linode jdamore-linode merged commit c80ded2 into linode:develop Nov 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants