Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7396] - Update axios to 1.6.1 #9911

Merged
merged 7 commits into from
Nov 17, 2023

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Nov 16, 2023

Description 📝

How to test 🧪

  • Test Cloud Manager in general
  • Verify file uploads for Object Storage and Images still work
  • Verify all CI and e2e pass

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Nov 16, 2023
@bnussman-akamai bnussman-akamai self-assigned this Nov 16, 2023
@bnussman-akamai
Copy link
Member Author

bnussman-akamai commented Nov 16, 2023

Without even debugging, I have 99% confidence that #9817 will resolve what's happening. Looks like a classic ESM/CJS problem

@bnussman-akamai bnussman-akamai marked this pull request as ready for review November 16, 2023 21:58
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner November 16, 2023 21:58
@bnussman-akamai bnussman-akamai requested review from mjac0bs and carrillo-erik and removed request for a team November 16, 2023 21:58
@bnussman-akamai bnussman-akamai changed the title change: Update Axios change: [M3-7396] - Update Axios Nov 16, 2023
@bnussman-akamai bnussman-akamai changed the title change: [M3-7396] - Update Axios change: [M3-7396] - Update axios to 1.6.1 Nov 16, 2023
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnussman-akamai! Seeing that the tests have passed, and spent some time messing around in Cloud Manager and everything seems to be working. Also checked file upload for OBJ and Images and those both worked like they normally do 👍

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked good -- did not notice any regressions. 🚀

  • Tested Cloud Manager in general - checked a variety of CRUD operations and error handling
  • Verified file uploads for Object Storage and Images still work
  • Verified all CI and e2e pass

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Nov 17, 2023
@bnussman-akamai bnussman-akamai merged commit d0792d6 into linode:develop Nov 17, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants