refactor: [M3-6522] - Tile and ShowMoreExpansion v7 Stories #9913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
force-pushed
the
M3-6522-tile-and-showmoreexpansion
branch
from
2533dc6 to
c8223cc
Compare
abailly-akamai
commented
Nov 27, 2023
| const meta: Meta<ShowMoreExpansionProps> = { | ||
| args: { | ||
| children: ( | ||
| <Typography> |
There was a problem hiding this comment.
old story was missing typography so font rendering was broken
abailly-akamai
requested review from
jdamore-linode,
dwiley-akamai and
coliu-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Nov 27, 2023
coliu-akamai
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Approving, stuff looks good! Had one question below about the tile component behavior unrelated to this PR (behavior already exists on prod).
- ✅ confirmed unit tests
- ✅ confirmed stories
- ✅ confirmed Cloud Manager
This is super super small but something that stuck out to me with the tile component is that the icon hover animation is delayed while the link hover isn't. Would it make more sense to have the animation happen at the same time, or is this (industry?) standard behavior?
| Story | Cloud - local & prod |
|---|---|
tile-delay1.mov |
tile-delay2.mov |
dwiley-akamai
approved these changes
Nov 27, 2023
packages/manager/.changeset/pr-9913-tech-stories-1701106649829.md
Outdated
Show resolved
Hide resolved
packages/manager/src/components/ShowMoreExpansion/ShowMoreExpansion.tsx
Outdated
Show resolved
Hide resolved
abailly-akamai
force-pushed
the
M3-6522-tile-and-showmoreexpansion
branch
from
07e7f1f to
009ed70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Small PR to migrate mdx to tsx stories for both Tile and ShowMoreExpansion components
Changes 🔄
Preview 📷
How to test 🧪
Verification steps
yarn storybookyarn upand make sure there isn't any regressions in either componentAs an Author I have considered 🤔
Check all that apply