test: [M3-6750] - VPC Delete tests #9920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
commented
Nov 20, 2023
Comment on lines
+25
to
+29
| React.useEffect(() => { | ||
| if (open) { | ||
| reset(); | ||
| } | ||
| }, [open, reset]); |
There was a problem hiding this comment.
On the VPC details page we disable subnet's delete action if the subnet still has linodes assigned to it -- the persistent error state is likely less of an issue here than the VPC delete dialog. Still added the fix to this dialog just in case some other error does appear bc we wouldn't want that to show up for some other subnet's delete dialog
coliu-akamai
requested review from
dwiley-akamai,
tyler-akamai,
jdamore-linode and
hana-akamai
and removed request for
a team
dwiley-akamai
approved these changes
Nov 20, 2023
coliu-akamai
added
Add'tl Approval Needed
jdamore-linode
approved these changes
Nov 21, 2023
| cy.wait(['@deleteVPCError']); | ||
| cy.findByText(MOCK_DELETE_VPC_ERROR).should('be.visible'); | ||
|
|
||
| // close Delete dialog for this VPC and open it up for the second VPC to confirm that error message does not persist |
There was a problem hiding this comment.
This is a nice extra detail to cover, good thinking!
coliu-akamai
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
Bug fix:
Screen.Recording.2023-11-20.at.11.22.20.AM.mov
bugfixed.mov
How to test 🧪
Prerequisites
For testing the bug
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
yarn test VPCDeleteDialogyarn cy:run -s "cypress/e2e/core/vpc/vpc-landing-page.spec.ts"As an Author I have considered 🤔
Check all that apply