-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-7449] - Dismissible Banner v7 story migration #9932
Merged
coliu-akamai
merged 6 commits into
linode:develop
from
coliu-akamai:m3-6522-dismissible-banner
Nov 27, 2023
Merged
refactor: [M3-7449] - Dismissible Banner v7 story migration #9932
coliu-akamai
merged 6 commits into
linode:develop
from
coliu-akamai:m3-6522-dismissible-banner
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
changed the title
refactor: [M3-7XXX] - Dismissible Banner v7 story migration
refactor: [M3-7449] - Dismissible Banner v7 story migration
Nov 22, 2023
coliu-akamai
requested review from
jaalah-akamai,
tyler-akamai and
abailly-akamai
and removed request for
a team
November 22, 2023 21:28
Verified:
|
tyler-akamai
approved these changes
Nov 27, 2023
abailly-akamai
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup and enhanced test! Approving pending fix for StyledLinkButton
packages/manager/src/components/DismissibleBanner/DismissibleBanner.styles.ts
Outdated
Show resolved
Hide resolved
coliu-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Ready for Review
labels
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes 🔄
How to test 🧪
Prerequisites
Verification steps
yarn test DismissibleBanner/DismissibleBanner.test.tsx
As an Author I have considered 🤔
Check all that apply