Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-7449] - Dismissible Banner v7 story migration #9932

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 22, 2023

Description 📝

  • MIgrated DismissibleBanner component story to a V7 (.tsx) story

Changes 🔄

  • migrated story
  • added tests
  • removed index file + updated exports

How to test 🧪

Prerequisites

  • pull code
  • yarn && yarn storybook

Verification steps

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai self-assigned this Nov 22, 2023
@coliu-akamai coliu-akamai changed the title refactor: [M3-7XXX] - Dismissible Banner v7 story migration refactor: [M3-7449] - Dismissible Banner v7 story migration Nov 22, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review November 22, 2023 21:28
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 22, 2023 21:28
@coliu-akamai coliu-akamai requested review from jaalah-akamai, tyler-akamai and abailly-akamai and removed request for a team November 22, 2023 21:28
@tyler-akamai
Copy link
Contributor

tyler-akamai commented Nov 27, 2023

Verified:

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup and enhanced test! Approving pending fix for StyledLinkButton

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Nov 27, 2023
@coliu-akamai coliu-akamai merged commit e6ce6c7 into linode:develop Nov 27, 2023
11 checks passed
@coliu-akamai coliu-akamai deleted the m3-6522-dismissible-banner branch December 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants