test: [M3-7315] - Add tests assgining VPCs during Linode creation flow #9939

cliu-akamai · 2023-11-28T16:57:19Z

Description 📝

Add regression tests for assigning VPCs during Linode creation flow.

Major Changes 🔄

Add regression tests to assign a VPC when creating a Linode.

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/create-linode.spec.ts"

coliu-akamai

Thanks Cassie! Left a comment below. Could we also add a changeset for this PR?

coliu-akamai · 2023-11-29T18:47:30Z

packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts

+    getVisible('[data-testid="vpc-panel"]').within(() => {
+      containsVisible('Assign this Linode to an existing VPC.');
+      // VPC in different region should not be available.
+      containsVisible('VPC is not available in the selected region.');


This text shows up when the region we've selected doesn't support VPCs. Since we're testing assigning a Linode to a VPC during creation, can we mock a region that supports VPCs and confirms this text doesn't show up? Then, could we test the user flow for assigning a VPC? For a region that supports VPCs, it looks like this:

assign-vpc-flow.mov

jdamore-linode

Great start @cliu-akamai! I left some feedback -- feel free to reach out if you have any questions!

jdamore-linode · 2023-11-29T18:02:11Z

packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts

  before(() => {
    cleanUp('linodes');
+    mockConfig.interfaces.splice(2, 1);


Can we create the mockConfig object with the expected interfaces rather than modifying them after the fact?

jdamore-linode · 2023-11-29T18:03:51Z

packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts

+  const region: Region = getRegionById('us-southeast');
+  const diskLabel: string = 'Debian 10 Disk';
+  const mockConfig: Config = linodeConfigFactory.build({
+    id: randomNumber(),
+  });
+  const mockDisks: Disk[] = [
+    {
+      id: 44311273,
+      status: 'ready',
+      label: diskLabel,
+      created: '2020-08-21T17:26:14',
+      updated: '2020-08-21T17:26:30',
+      filesystem: 'ext4',
+      size: 81408,
+    },
+    {
+      id: 44311274,
+      status: 'ready',
+      label: '512 MB Swap Image',
+      created: '2020-08-21T17:26:14',
+      updated: '2020-08-21T17:26:31',
+      filesystem: 'swap',
+      size: 512,
+    },
+  ];
+  const mockVLANs: VLAN[] = VLANFactory.buildList(2);
+  const mockVPCs: VPC[] = vpcFactory.buildList(5, {
+    region: 'us-southeast',
+  });


Can we move these to the VPC assignment test since they're not shared by any of the other tests?

jdamore-linode · 2023-11-29T18:54:41Z

packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts

+    // the "VPC" section is present, and the VPC in the same region of
+    // the linode can be selected.
+    getVisible('[data-testid="vpc-panel"]').within(() => {
+      containsVisible('Assign this Linode to an existing VPC.');
+      // VPC in different region should not be available.
+      containsVisible('VPC is not available in the selected region.');
+    });


I think we'll need to do more here -- it's good that we're confirming the state of the UI when VPC isn't available, but we primarily want this test to be able to select a VPC and proceed with the Linode creation.

I think this might require some changes and additions to the mocks, specifically:

mockGetVPCs should be passed an array of VPC objects which contains the mockVPC object you created -- this should allow the mock to appear in the list of VPCs when attempting to select it

We'll probably need to mock the regions request so that us-southeast has the VPCs capability (we do something similar in the VPC create test).

jdamore-linode · 2023-11-29T18:58:10Z

packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts

+    mockGetVLANs(mockVLANs);
+    mockGetVPC(mockVPC).as('getVPC');
+    mockCreateLinode(mockLinode).as('linodeCreated');
+    mockGetLinodeConfigs(mockLinode.id, [mockConfig]).as('getLinodeConfigs');
+    mockGetLinodeDisks(mockLinode.id, mockDisks).as('getDisks');
+    mockGetLinodeVolumes(mockLinode.id, []).as('getVolumes');


We'll probably want to move these calls before cy.visitWithLogin() -- putting them here usually works, but it can be flaky because it's possible for Cloud to make these HTTP requests before Cypress sets up the intercepts.

github-actions · 2023-12-05T22:41:56Z

Coverage Report: ✅
Base Coverage: 80.18%
Current Coverage: 80.18%

coliu-akamai

awesome, thanks Cassie!
✅ confirmed both tests work as expected

It may or may not be out of scope for this ticket - should we also have a test for creating a VPC in the Linode Create flow and assigning it to this Linode? I can create a new ticket for it if needed @jdamore-linode

coliu-akamai · 2023-12-18T14:45:26Z

packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts

@@ -321,4 +336,181 @@ describe('create linode', () => {
    fbtVisible(linodeLabel);
    cy.contains('RUNNING', { timeout: 300000 }).should('be.visible');
  });
+
+  it('assigns a VPC not enabled in the region to the linode during create flow', () => {


Suggested change

it('assigns a VPC not enabled in the region to the linode during create flow', () => {

it('prevents a VPC from being assigned in a region that doesn't support VPCs during the Linode Create flow', () => {

coliu-akamai · 2023-12-18T14:46:09Z

packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts

+      containsVisible(
+        'Allow Linode to communicate in an isolated environment.'
+      );
+      // VPC in different region should not be available.


Suggested change

// VPC in different region should not be available.

// Helper text appears if VPC is not available in selected region

jaalah-akamai · 2024-01-17T15:17:44Z

I had 3 tests fail for me:

hkhalil-akamai

Tests overall look good. Highlighting one small issues causing failures for me locally.

hkhalil-akamai · 2024-01-22T21:42:56Z

packages/manager/cypress/e2e/core/linodes/create-linode.spec.ts

+    cy.contains('RUNNING', { timeout: 300000 }).should('be.visible');
+
+    fbtClick('Configurations');
+    cy.wait(['@getLinodeConfigs', '@getVPC', '@getDisks', '@getVolumes']);


Seeing this error repeatedly across runs -- I think it originates from this line.

Might be related to this 404? Do we need to add a mock for this route?

jdamore-linode

Thanks @hkhalil-akamai! Just pushed a couple commits that should resolve the merge conflict and fix this failure.

@cliu-akamai Nice work! Approved pending Cypress test results -- thanks for addressing the feedback and sorry for the slow follow up on my end!

…eate flow

hkhalil-akamai

Thanks for addressing feedback!

cliu-akamai requested a review from a team as a code owner November 28, 2023 16:57

cliu-akamai requested review from bnussman-akamai and tyler-akamai and removed request for a team November 28, 2023 16:57

coliu-akamai assigned cliu-akamai Nov 29, 2023

coliu-akamai added Testing Ready for Review VPC Relating to VPC project labels Nov 29, 2023

coliu-akamai reviewed Nov 29, 2023

View reviewed changes

jdamore-linode requested changes Nov 29, 2023

View reviewed changes

cliu-akamai force-pushed the feature/M3-7315 branch from f06a105 to 09ba643 Compare December 5, 2023 22:21

cliu-akamai requested a review from a team as a code owner December 5, 2023 22:21

cliu-akamai requested review from jdamore-linode and removed request for a team December 5, 2023 22:21

cliu-akamai requested a review from coliu-akamai December 7, 2023 17:32

cliu-akamai changed the title ~~M3-7315 Add tests assgining VPCs during Linode creation flow~~ test: [M3-7315] - Add tests assgining VPCs during Linode creation flow Dec 7, 2023

coliu-akamai approved these changes Dec 18, 2023

View reviewed changes

coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Dec 20, 2023

cliu-akamai added 2 commits January 4, 2024 12:29

M3-7315 Add tests assgining VPCs during Linode creation flow

a9f86da

Fix comments

d22a4a0

cliu-akamai force-pushed the feature/M3-7315 branch from 09ba643 to d22a4a0 Compare January 4, 2024 17:33

hkhalil-akamai requested changes Jan 22, 2024

View reviewed changes

Joe D'Amore added 2 commits January 23, 2024 15:22

Merge branch 'develop' into feature/M3-7315, update VPC mocks

6f4a573

Remove .only

11b2550

jdamore-linode approved these changes Jan 23, 2024

View reviewed changes

jdamore-linode added the Missing Changeset label Jan 23, 2024

Added changeset: Add Cypress test for VPC assignment during Linode cr…

c72dc41

…eate flow

jdamore-linode removed the Missing Changeset label Jan 23, 2024

Improve test name, replace region ID to account for mock changes

8324ca1

jdamore-linode requested a review from hkhalil-akamai January 24, 2024 15:37

bnussman-akamai approved these changes Jan 26, 2024

View reviewed changes

bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 26, 2024

hkhalil-akamai approved these changes Jan 26, 2024

View reviewed changes

jdamore-linode merged commit 7663ebd into linode:develop Jan 29, 2024
18 checks passed

cpathipa mentioned this pull request Feb 1, 2024

Release v1.111.0 - release → staging #10136

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: [M3-7315] - Add tests assgining VPCs during Linode creation flow #9939

test: [M3-7315] - Add tests assgining VPCs during Linode creation flow #9939

cliu-akamai commented Nov 28, 2023

coliu-akamai left a comment

coliu-akamai Nov 29, 2023 •

edited

Loading

jdamore-linode left a comment

jdamore-linode Nov 29, 2023

jdamore-linode Nov 29, 2023

jdamore-linode Nov 29, 2023

jdamore-linode Nov 29, 2023

github-actions bot commented Dec 5, 2023 •

edited

Loading

coliu-akamai left a comment •

edited

Loading

coliu-akamai Dec 18, 2023

coliu-akamai Dec 18, 2023

jaalah-akamai commented Jan 17, 2024

hkhalil-akamai left a comment

hkhalil-akamai Jan 22, 2024

hkhalil-akamai Jan 22, 2024

jdamore-linode left a comment

hkhalil-akamai left a comment

	it('assigns a VPC not enabled in the region to the linode during create flow', () => {
	it('prevents a VPC from being assigned in a region that doesn't support VPCs during the Linode Create flow', () => {

	// VPC in different region should not be available.
	// Helper text appears if VPC is not available in selected region

test: [M3-7315] - Add tests assgining VPCs during Linode creation flow #9939

test: [M3-7315] - Add tests assgining VPCs during Linode creation flow #9939

Conversation

cliu-akamai commented Nov 28, 2023

Description 📝

Major Changes 🔄

How to test 🧪

coliu-akamai left a comment

Choose a reason for hiding this comment

coliu-akamai Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

jdamore-linode left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2023 • edited Loading

coliu-akamai left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaalah-akamai commented Jan 17, 2024

hkhalil-akamai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdamore-linode left a comment

Choose a reason for hiding this comment

hkhalil-akamai left a comment

Choose a reason for hiding this comment

coliu-akamai Nov 29, 2023 •

edited

Loading

github-actions bot commented Dec 5, 2023 •

edited

Loading

coliu-akamai left a comment •

edited

Loading