Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7214 - M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows pt1 #9943

Merged
merged 10 commits into from
Nov 30, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Nov 28, 2023

Description 📝

  • The bulk of the logic for disabling regions was implemented here! 🎉 This PR adds some additional logic to disable regions when creating various entities:
    • Linodes/Migrating Linodes
    • Volumes
    • Nodebalancers
    • Managed Databases
    • Object Storage

There will be a part 2 PR for additional stuff later - definitely Kubernetes, potentially Service Transfers

Changes 🔄

  • Updated getRegionOptions in RegionSelect to filter regions based on capability - only show the regions that actually support whichever capability we pass in + added relevant test
  • Update MSW so that we can see a disabled region in Object Storage & Databases
  • Add logic for disabled regions in Linodes/Migrate Linodes, Volume, Nodebalancers, Managed Databases, Object Storage
  • update tooltip copy & link

Preview 📷

MSW - Linodes MSW - volumes
image image

How to test 🧪

Verification steps

  • Without the MSW (and with/without the DC get well feature flag), for each flow listed above
    • Verify that the creation (or migration) flow for each entity still works as expected
    • Verify that this PR still has the same regions as prod
      • ** Tokyo no longer appears in this PR bc we've removed fake regions
      • ** order of continent/regions may not be the same, we've alphabetized everything
  • With the MSW + dc get well feature flag, for each flow
    • Verify that disabled regions appear as expected for each entity/capability (see mock data for account/availability endpoint in serverHandlers.ts)
    • Verify that if a region doesn't have a capability for some entity, that region doesn't appear. You can do this by adding or removing capabilities in regions.json
    • clicking on the "learn more" link takes you to https://www.linode.com/global-infrastructure/availability (page does not yet exist but will soon)
  • yarn test components/RegionSelect

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai added Work in Progress DC Get Well Relating to the DC Get Well project labels Nov 28, 2023
@coliu-akamai coliu-akamai self-assigned this Nov 28, 2023
@coliu-akamai coliu-akamai changed the title upcoming: [M3-7215, M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows upcoming: [M3-7215, M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows pt1 Nov 28, 2023
@coliu-akamai coliu-akamai changed the title upcoming: [M3-7215, M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows pt1 upcoming: [M3-7214 - M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows pt1 Nov 28, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review November 29, 2023 14:53
@coliu-akamai coliu-akamai requested a review from a team as a code owner November 29, 2023 14:53
@coliu-akamai coliu-akamai requested review from jaalah-akamai and abailly-akamai and removed request for a team November 29, 2023 14:53
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Confirmed:

  • New services adopting new region filtering and disabled regions showing as expected from mocks ✅
  • No regressions in region filtering based on capabilities ✅
  • UI and copy for the tooltip ✅
  • e2e failure isn't happening locally ✅

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I was able to see the tooltip with capabilities

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Nov 30, 2023
@coliu-akamai coliu-akamai merged commit d1af35e into linode:develop Nov 30, 2023
13 checks passed
@coliu-akamai coliu-akamai deleted the feat-m3-7215 branch December 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DC Get Well Relating to the DC Get Well project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants