-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7214 - M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows pt1 #9943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
added
Work in Progress
DC Get Well
Relating to the DC Get Well project
labels
Nov 28, 2023
coliu-akamai
changed the title
upcoming: [M3-7215, M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows
upcoming: [M3-7215, M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows pt1
Nov 28, 2023
coliu-akamai
changed the title
upcoming: [M3-7215, M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows pt1
upcoming: [M3-7214 - M3-7216, M3-7219, M3-7221, M3-7222] - Add DC Get Well logic to various user flows pt1
Nov 28, 2023
coliu-akamai
requested review from
jaalah-akamai and
abailly-akamai
and removed request for
a team
November 29, 2023 14:53
coliu-akamai
force-pushed
the
feat-m3-7215
branch
from
November 29, 2023 20:38
7605b76
to
cd27c42
Compare
abailly-akamai
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Confirmed:
- New services adopting new region filtering and disabled regions showing as expected from mocks ✅
- No regressions in region filtering based on capabilities ✅
- UI and copy for the tooltip ✅
- e2e failure isn't happening locally ✅
packages/manager/src/components/SelectRegionPanel/SelectRegionPanel.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/RegionSelect/RegionSelect.utils.ts
Outdated
Show resolved
Hide resolved
…required prop comments in pt2
jaalah-akamai
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I was able to see the tooltip with capabilities
coliu-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Ready for Review
labels
Nov 30, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
There will be a part 2 PR for additional stuff later - definitely Kubernetes, potentially Service Transfers
Changes 🔄
getRegionOptions
inRegionSelect
to filter regions based on capability - only show the regions that actually support whichever capability we pass in + added relevant testPreview 📷
How to test 🧪
Verification steps
account/availability
endpoint inserverHandlers.ts
)regions.json
yarn test components/RegionSelect
As an Author I have considered 🤔
Check all that apply