upcoming: [M3-7220, M3-7355] - Add DC Get Well logic to various user flows pt2 and cleanup #9945

coliu-akamai · 2023-11-30T15:21:09Z

Description 📝

Adds some additional logic to disable regions when creating kubernetes
cleans up existing DC Get Well logic (make a prop required, clean up comments) + update tests as needed

Preview 📷

kubernetes msw

How to test 🧪

Prerequisites

Verification steps

Without the MSW (and with/without the DC get well feature flag), for Kubernetes and VPCs

Verify that the creation (or migration) flow for each entity still works as expected
Verify that this PR still has the same regions as prod
- ** Tokyo no longer appears in this PR bc we've removed fake regions
- ** order of continent/regions may not be the same, we've alphabetized everything

With the MSW + dc get well feature flag, for Kubernetes only

Verify that disabled regions appear as expected for each entity/capability (see mock data for account/availability endpoint in serverHandlers.ts)
Verify that if a region doesn't have a capability for some entity, that region doesn't appear. You can do this by adding or removing capabilities in regions.json
clicking on the "learn more" link takes you to https://www.linode.com/global-infrastructure/availability (page does not yet exist but will soon)

As an Author I have considered 🤔

Check all that apply

coliu-akamai · 2023-11-30T15:23:57Z

packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx

-  React.useEffect(() => {
-    if (filteredRegions.length === 1 && !selectedRegionID) {
-      setSelectedRegionID(filteredRegions[0].id);
-    }
-  }, [filteredRegions, selectedRegionID]);


Deleted this logic to preselect a region if there's only one region with kubernetes capability: we've moved the region filtering logic inside the RegionSelect (filteredRegions is no longer declared). We can't preselect a region anymore because we can no longer assume that all regions in regionsData have Kubernetes as a capability, even if regionsData.length === 1.

…required prop comments in pt2

abailly-akamai

🎉 Looks great

confirmed the proper behavior for those services RegionSelects ✅
confirmed comments and cleanups ✅

jdamore-linode

Looks good, thanks Connie! Confirmed the flows in your description. Thanks for the thorough doc comments too!

dwiley-akamai

Without the MSW (and with/without the DC get well feature flag), for Kubernetes and VPCs:

Creation flow for each entity still works as expected ✅
This branch has the same regions as prod ✅
- Tokyo no longer appears in this PR bc we've removed fake regions ✅
- Order of continent/regions may not be the same, we've alphabetized everything ✅

With the MSW + dc get well feature flag, for Kubernetes only:

Disabled regions appear as expected for each entity/capability ✅
If a region doesn't have a capability for some entity, that region doesn't appear ✅
Clicking on the "learn more" link takes you to https://www.linode.com/global-infrastructure/availability ✅

dwiley-akamai · 2023-12-01T16:26:49Z

packages/manager/src/components/RegionSelect/RegionSelect.types.ts

+   * Only use `undefined` for situations where there is no relevant capability for the RegionSelect - this will not filter any of the regions passed in.
+   * Otherwise, a capability should always be passed in.
+   *
+   * See `ImageUpload.tsx` for an example of a RegionSelect with an undefined `currentCapability` - there is no capability associated with Images yet.


"there is no capability associated with Images yet" -- is this something API is planning on adding?

I'm not completely sure to be honest. Images is currently out of scope, but we'll make a backlog ticket to ask API about this soon

Edit: M3-7525

coliu-akamai added 11 commits November 28, 2023 16:19

dc get well logic to various create flows

f55faf4

linode create flow dc get well

be6517f

add logic to filter regions based on capability

f1583d1

changeset, update comment

443374b

slight cleanup

5f21ca8

disable region for dbaas

96fc62d

fix e2e tests: specify capabilities

cd27c42

tooltip confirmed copy and link :D

8b3dd0a

update tooltip width

c808a5c

kubernetes region

7aa827b

add currentCapability to VPC logic

6756ee3

coliu-akamai added Wait to Merge DC Get Well Relating to the DC Get Well project labels Nov 30, 2023

coliu-akamai self-assigned this Nov 30, 2023

coliu-akamai commented Nov 30, 2023

View reviewed changes

coliu-akamai added 2 commits November 30, 2023 10:28

remove comments I added in this PR - will remove rest of dc get well …

cab1a59

…required prop comments in pt2

Merge branch 'feat-m3-7215' into m3-7220

9e95bb8

coliu-akamai changed the title ~~upcoming: [M3-7220] - Add DC Get Well logic to various user flows pt1 and cleanup~~ upcoming: [M3-7220, M3-7355] - Add DC Get Well logic to various user flows pt1 and cleanup Nov 30, 2023

coliu-akamai added 2 commits November 30, 2023 11:17

update comments

944da0f

Merge branch 'develop' into m3-7220

d4b22b7

coliu-akamai removed the Wait to Merge label Nov 30, 2023

coliu-akamai changed the title ~~upcoming: [M3-7220, M3-7355] - Add DC Get Well logic to various user flows pt1 and cleanup~~ upcoming: [M3-7220, M3-7355] - Add DC Get Well logic to various user flows pt2 and cleanup Nov 30, 2023

fix kubernetes styling and add changeset

ddaf20a

coliu-akamai marked this pull request as ready for review November 30, 2023 20:30

coliu-akamai requested a review from a team as a code owner November 30, 2023 20:30

coliu-akamai requested review from jdamore-linode, dwiley-akamai and abailly-akamai and removed request for a team November 30, 2023 20:30

feedback

4bd3378

abailly-akamai approved these changes Nov 30, 2023

View reviewed changes

coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Nov 30, 2023

jdamore-linode approved these changes Dec 1, 2023

View reviewed changes

dwiley-akamai approved these changes Dec 1, 2023

View reviewed changes

coliu-akamai merged commit 2f467dc into linode:develop Dec 1, 2023
11 checks passed

coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 1, 2023

coliu-akamai deleted the m3-7220 branch December 8, 2023 16:05

mjac0bs mentioned this pull request Dec 11, 2023

Release v1.108.0 - staging → master #9986

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [M3-7220, M3-7355] - Add DC Get Well logic to various user flows pt2 and cleanup #9945

upcoming: [M3-7220, M3-7355] - Add DC Get Well logic to various user flows pt2 and cleanup #9945

coliu-akamai commented Nov 30, 2023 •

edited

Loading

coliu-akamai Nov 30, 2023 •

edited

Loading

abailly-akamai left a comment

jdamore-linode left a comment

dwiley-akamai left a comment

dwiley-akamai Dec 1, 2023

coliu-akamai Dec 1, 2023 •

edited

Loading

upcoming: [M3-7220, M3-7355] - Add DC Get Well logic to various user flows pt2 and cleanup #9945

upcoming: [M3-7220, M3-7355] - Add DC Get Well logic to various user flows pt2 and cleanup #9945

Conversation

coliu-akamai commented Nov 30, 2023 • edited Loading

Description 📝

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

coliu-akamai Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

abailly-akamai left a comment

Choose a reason for hiding this comment

jdamore-linode left a comment

Choose a reason for hiding this comment

dwiley-akamai left a comment

Choose a reason for hiding this comment

dwiley-akamai Dec 1, 2023

Choose a reason for hiding this comment

coliu-akamai Dec 1, 2023 • edited Loading

Choose a reason for hiding this comment

coliu-akamai commented Nov 30, 2023 •

edited

Loading

coliu-akamai Nov 30, 2023 •

edited

Loading

coliu-akamai Dec 1, 2023 •

edited

Loading