Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7492] – VPC Landing page empty state resource links & copy updates #9951

Merged

Conversation

dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented Dec 1, 2023

Description πŸ“

Update copy and resource links for the empty state VPC landing page.

Changes πŸ”„

  • Minor copy tweaks
  • Resource links added (links have not yet been published yet so the hyperlinks won't work at this point, but the URLs have been finalized)

Preview πŸ“·

Screenshot 2023-12-01 at 12 55 27 PM

How to test πŸ§ͺ

Prerequisites

  • MSW

Verification steps

If you have VPCs on your account already, the easiest way to test this would be turning the MSW, commenting these lines out in serverHandlers.ts, and refreshing the page:

...vpcsWithSubnet1,
...vpcsWithSubnet2,
...vpcsWithoutSubnet,

Confirm that:

  • Copy matches the ticket/mockup
  • Links match what's listed in the ticket

As an Author I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@dwiley-akamai dwiley-akamai added the VPC Relating to VPC project label Dec 1, 2023
@dwiley-akamai dwiley-akamai self-assigned this Dec 1, 2023
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner December 1, 2023 18:03
@dwiley-akamai dwiley-akamai requested review from carrillo-erik and coliu-akamai and removed request for a team December 1, 2023 18:03
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… confirmed links and design match as expected

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 1, 2023
@coliu-akamai
Copy link
Contributor

coliu-akamai commented Dec 1, 2023

We'll need to update the e2e tests for the VPC landing page (2nd test, line 74), since the Video Playlist section no longer exists (not sure if they plan to add that back in). We could add some checks to verify the other text you added ("Overview of Virtual Private Clouds (VPCs)", etc) is present in that test too

@dwiley-akamai dwiley-akamai requested a review from a team as a code owner December 1, 2023 21:54
@dwiley-akamai dwiley-akamai requested review from cliu-akamai and removed request for a team December 1, 2023 21:54
@dwiley-akamai
Copy link
Contributor Author

We could add some checks to verify the other text you added ("Overview of Virtual Private Clouds (VPCs)", etc) is present in that test too

I think there's a decent chance of the copy being tweaked further before/during GA and I didn't see other analogous E2E tests (e.g., lke-landing-page.spec.ts) getting as granular as the individual link level so I opted to not add those at this stage. Keeping an eye on the test to make sure it passes with the removal of the assertion re: the Video Playlist

Copy link

github-actions bot commented Dec 1, 2023

Coverage Report: βœ…
Base Coverage: 85.46%
Current Coverage: 85.47%

@dwiley-akamai dwiley-akamai merged commit 41ea4c0 into linode:develop Dec 5, 2023
13 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-7492-ux-copy-update-vpc-landing branch December 5, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants