-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7492] β VPC Landing page empty state resource links & copy updates #9951
change: [M3-7492] β VPC Landing page empty state resource links & copy updates #9951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β confirmed links and design match as expected
We'll need to update the e2e tests for the VPC landing page (2nd test, line 74), since the Video Playlist section no longer exists (not sure if they plan to add that back in). We could add some checks to verify the other text you added ("Overview of Virtual Private Clouds (VPCs)", etc) is present in that test too |
I think there's a decent chance of the copy being tweaked further before/during GA and I didn't see other analogous E2E tests (e.g., |
Coverage Report: β
|
Description π
Update copy and resource links for the empty state VPC landing page.
Changes π
Preview π·
How to test π§ͺ
Prerequisites
Verification steps
If you have VPCs on your account already, the easiest way to test this would be turning the MSW, commenting these lines out in
serverHandlers.ts
, and refreshing the page:manager/packages/manager/src/mocks/serverHandlers.ts
Lines 443 to 445 in 1141d10
Confirm that:
As an Author I have considered π€