Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-7532] - Payment Method Row Storybook v7 Story #9958

Merged
merged 9 commits into from
Dec 5, 2023
Merged

refactor: [M3-7532] - Payment Method Row Storybook v7 Story #9958

merged 9 commits into from
Dec 5, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Dec 4, 2023 •
edited
Loading

Description 📝

  • MIgrate PaymentMethodRow component story to a V7 (.tsx) story

Changes 🔄

  • migrate to .tsx story
  • add tests for Delete payment method confirmation dialog
  • update imports/exports, switch to tss-mui

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai self-assigned this Dec 4, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review December 4, 2023 20:26
@coliu-akamai coliu-akamai requested a review from a team as a code owner December 4, 2023 20:26
@coliu-akamai coliu-akamai requested review from jdamore-linode and cpathipa and removed request for a team December 4, 2023 20:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Coverage Report: ✅
Base Coverage: 85.63%
Current Coverage: 86.55%

abailly-akamai
abailly-akamai approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

  • story renders well ✅
  • test look good and passing ✅

packages/manager/src/components/PaymentMethodRow/DeletePaymentMethodDialog.test.tsx Show resolved Hide resolved
packages/manager/src/components/PaymentMethodRow/PaymentMethodRow.stories.tsx Outdated Show resolved Hide resolved
@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Dec 5, 2023
bnussman-akamai
bnussman-akamai approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💳🎉

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 5, 2023
@coliu-akamai coliu-akamai merged commit 5623a50 into linode:develop Dec 5, 2023
14 of 15 checks passed
@mjac0bs mjac0bs mentioned this pull request Dec 11, 2023
Merged
@coliu-akamai coliu-akamai deleted the m3-7532 branch December 19, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@jdamore-linode jdamore-linode Awaiting requested review from jdamore-linode jdamore-linode is a code owner automatically assigned from linode/frontend

@cpathipa cpathipa Awaiting requested review from cpathipa cpathipa is a code owner automatically assigned from linode/frontend

Assignees

@coliu-akamai coliu-akamai

Labels
Approved Multiple approvals and ready to merge! Storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coliu-akamai @bnussman-akamai @abailly-akamai