Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-7428] - Create feature flag to support OBJ Multi Cluster UI changes #9970

Merged
merged 2 commits into from
Dec 6, 2023
Merged

upcoming: [M3-7428] - Create feature flag to support OBJ Multi Cluster UI changes #9970

merged 2 commits into from
Dec 6, 2023

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Dec 6, 2023

Description 📝

Feature flag to support OBJ Multi Cluster UI changes.

@cpathipa cpathipa requested a review from a team as a code owner December 6, 2023 17:25
@cpathipa cpathipa requested review from hana-akamai and coliu-akamai and removed request for a team December 6, 2023 17:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Coverage Report: ✅
Base Coverage: 86.51%
Current Coverage: 86.51%

coliu-akamai
coliu-akamai approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed useFlags returns objMultiCluster and that it shows up in feature flags section ✅
image

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 6, 2023
@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 6, 2023
@cpathipa cpathipa merged commit 2b0bf7a into linode:develop Dec 6, 2023
14 of 15 checks passed
@mjac0bs mjac0bs mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@hana-akamai hana-akamai Awaiting requested review from hana-akamai hana-akamai is a code owner automatically assigned from linode/frontend

@dwiley-akamai dwiley-akamai Awaiting requested review from dwiley-akamai

Assignees

@cpathipa cpathipa

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpathipa @bnussman-akamai @coliu-akamai