fix: [M3-7533] - RegionSelect sorting in Firefox

[abailly-akamai]

Description 📝

This giant PR fixes a small issue with the region select DCs not being sorted properly in Firefox.

Changes 🔄

• Adjust RegionSelect sorting util

Preview 📷

Before (Firefox)	After (Firefox)

How to test 🧪

Reproduction steps

• on develop & while using firefox, go to a create flow featuring the RegionSelect and notice the DCs are not alphabetically sorted.

Verification steps

• on this branch & while using firefox, go to a create flow featuring the RegionSelect and notice the DCs are now properly alphabetically sorted.
• Ensure there's no regression in the sorting for other Browsers (chrome & safari most importantly)

As an Author I have considered 🤔

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[coliu-akamai]

biggest pr i've ever seen 😆

Confirmed regions are now sorted on Firefox, and chrome + safari are the same ✅

[github-actions]

Coverage Report: ❌
Base Coverage: 86.51%
Current Coverage: 86.49%

[mjac0bs]

✅ Regions are alphabetically sorted in Firefox in the same order they are on Chrome and Safari.

❓ This might have been discussed in previous RegionSelect PRs and I'm lacking context, but did we recently decide to sort alphabetically by region regardless of country?

In prod, we sort alpha by country and so Toronto appears below Washington. In dev and this branch, Toronto is in alpha order within the US DCs. Same situation with Asia.

Prod	Dev/This Branch

[abailly-akamai]

@mjac0bs yup this has been discussed and approved by UI - they are in the process or refactoring-redesigning this component but in the meantime the alphabetical approach for ordering DCs within their groups has been pushed forward.

[abailly-akamai]

@mjac0bs @coliu-akamai I also added grouping by country to make things a bit more readable on Mariah's suggestion - please feel free to take another look before I merge tomorrow. Thank you!

[mjac0bs]

Looks like that change resulted in a unit test failure because the test case is expecting a CA region to come before the US still, since they're both North America.

Edit: Also, this doesn't need a changeset, does it? This never made it to prod.

Approving since aside from that, I confirmed that sorting is happening by Region and then by Country in Chrome, Firefox, and Safari, which now matches prod. Thanks for making that country sort change - in the absence of final UX guidance, I think it is for the best that we keep prod's current sorting and easy visual navigation by flag. While it's not currently ideal for regions like Europe, I suspect that users in those regions are accustomed to their region's placement.

[coliu-akamai]

thanks Alban and Mariah! Reconfirmed sorting + confirmed grouping by country

[cpathipa]

Observation: DC : Singapore, SG is disabled in Chrome. But, enabled in Safari and Firefox (Able to select this option).

(Chrome)	(Firefox & safari)

[cpathipa]

Only observation found is DC: Singapore, SG was enabled in Firefox and safari. But, disabled in chrome.

[abailly-akamai]

@cpathipa I can't reproduce. Please make sure you are testing:

• on the same account
• with the DC Get Well flag enabled
• with MSW on

[cpathipa]

@cpathipa I can't reproduce. Please make sure you are testing:

• on the same account
• with the DC Get Well flag enabled
• with MSW on

@abailly-akamai Sorry, My bad, that's due to different account in chrome. Confirming that sorting is working as expected in Firefox and no regression found.