test: [M3-6608] - Add Linode power off, power on and reboot tests #9980
Conversation
cliu-akamai
requested review from
jdamore-linode
and removed request for
a team
cliu-akamai
requested review from
carrillo-erik and
tyler-akamai
and removed request for
a team
|
Coverage Report: ✅ |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@linode/manager": Added | |||
There was a problem hiding this comment.
I had a similar PR where I only added new tests and was unsure of which identifier to use for the changeset. In my case I ended up going with Tests. My decision was based on the descriptions found under the Commit Types in the Pull Request Template:
test: New tests or changes to existing tests. Does not change the production code.
There was a problem hiding this comment.
+1 to using tests for the changeset category
|
Looks good. I ran the tests locally and verified that they all passed ✅ ✅ ✅
|
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@linode/manager": Added | |||
There was a problem hiding this comment.
+1 to using tests for the changeset category
| .should('be.visible') | ||
| .within(() => { | ||
| containsVisible('Shutting Down'); | ||
| cy.contains('Offline', { timeout: 300000 }).should('be.visible'); |
There was a problem hiding this comment.
is 5 minutes too long? Not sure what our standards are.
|
LGTM, nice clean tests. I dont have baker access, but not sure whats causing the failure. |
Description 📝
Add regression tests for powering on/off and rebooting Linodes
Major Changes 🔄
How to test 🧪