-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7526] - Add setHeader to GET /profile endpoint #9987
feat: [M3-7526] - Add setHeader to GET /profile endpoint #9987
Conversation
Coverage Report: ✅ |
Just a heads up that the E2E test failures all seem to stem from HTTP 500 responses from the API during resource clean up and aren't caused by these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I confirmed that I see another request to /profile
on behalf of the account we're passing a token in for, and their username is available:
Thanks for your work on this! If you get a chance to update the internal ticket based on our discussion, that would be great.
Edit: The tests that failed in CI are billing/smoke-billing-activity.spec.ts
(passes locally) and account/sms-verification.spec.ts
, which seems to be failing consistently locally when looking for the phone number to display after it's verified, and it doesn't. This test passed in develop
, so not quite sure what's happening here.
packages/manager/.changeset/pr-9987-upcoming-features-1702333742297.md
Outdated
Show resolved
Hide resolved
@tyler-akamai You may need to update this branch to avoid all the file noise we're seeing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good 👍
Description 📝
In order for the proxy account to access the username of the parent account, we need to use the auth token of the parent to collect the parent's profile info on behalf of the proxy account. We will have the parent account's token available to us for this use after storing it in local storage when the parent logs in as the proxy user via the "Switch Account" button.
Changes 🔄
List any change relevant to the reviewer.
How to test 🧪
undefined
param from theuseProfile
callAs an Author I have considered 🤔
Check all that apply