Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7446] - VLAN availability text on Linode Create #9989

Merged
merged 8 commits into from
Dec 15, 2023

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Dec 12, 2023

Description 📝

This PR refactors the list of VLAN available regions in the VLAN Linode Create flow since it was too long and hard to read.

Changes 🔄

  • Implement new notice with tooltip containing VLAN available regions (both in legacy Panel and VPC accordion)
  • Implement VPC accordion test (only since panel is about to be deprecated)

Preview 📷

Before After
Screenshot 2023-12-13 at 14 01 42 Screenshot 2023-12-13 at 14 01 15
Screenshot 2023-12-13 at 14 02 02 Screenshot 2023-12-13 at 14 01 00

How to test 🧪

Verification steps

  • Pull & run code locally
  • Navigate to linode/create, scroll down to the VLAN panel and confirm updated panel with copy & regions tooltip
  • Turn on the VPC flag, navigate to linode/create, scroll down to the VLAN accordion and expand it, and confirm updated copy & regions tooltip

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Dec 12, 2023
@abailly-akamai abailly-akamai marked this pull request as ready for review December 13, 2023 19:12
@abailly-akamai abailly-akamai requested a review from a team as a code owner December 13, 2023 19:12
@abailly-akamai abailly-akamai requested review from dwiley-akamai and cpathipa and removed request for a team December 13, 2023 19:12
Copy link

github-actions bot commented Dec 13, 2023

Coverage Report:
Base Coverage: 77.52%
Current Coverage: 77.53%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VLAN panel & accordion have updated copy & regions tooltip ✅
VLANAccordion.test.tsx passes ✅
Code review ✅

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay thanks Alban, this looks a lot cleaner! 🎉

✅ website
✅ unit tests
✅ code review

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Dec 14, 2023
@abailly-akamai
Copy link
Contributor Author

Confirmed e2e failues are unrelated - those smoke tests are passing locally consistently

@abailly-akamai abailly-akamai merged commit 249ad93 into linode:develop Dec 15, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants