-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming, change: [M3-7524] - Add child_account OAuth scope to Create and View PAT drawers #9992
Merged
mjac0bs
merged 13 commits into
linode:develop
from
mjac0bs:M3-7411-add-new-oauth-scope-to-new-endpoints
Dec 20, 2023
Merged
upcoming, change: [M3-7524] - Add child_account OAuth scope to Create and View PAT drawers #9992
mjac0bs
merged 13 commits into
linode:develop
from
mjac0bs:M3-7411-add-new-oauth-scope-to-new-endpoints
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
force-pushed
the
M3-7411-add-new-oauth-scope-to-new-endpoints
branch
from
December 13, 2023 23:38
70f1a49
to
adb0d02
Compare
mjac0bs
changed the title
upcoming: [M3-7411] - Add child_account OAuth scope to Create and View PAT drawers
upcoming: [M3-7524] - Add child_account OAuth scope to Create and View PAT drawers
Dec 18, 2023
mjac0bs
commented
Dec 18, 2023
packages/manager/src/features/Profile/APITokens/CreateAPITokenDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Profile/APITokens/CreateAPITokenDrawer.tsx
Outdated
Show resolved
Hide resolved
mjac0bs
requested review from
cpathipa,
coliu-akamai and
tyler-akamai
and removed request for
a team
December 18, 2023 23:05
packages/manager/src/features/Profile/APITokens/ViewAPITokenDrawer.tsx
Outdated
Show resolved
Hide resolved
jaalah-akamai
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending some revisions - I was able to test everything as listed and the tests passed ✅
Verified:
LGTM 🚀 |
Coverage Report: ✅ |
tyler-akamai
approved these changes
Dec 19, 2023
mjac0bs
changed the title
upcoming: [M3-7524] - Add child_account OAuth scope to Create and View PAT drawers
upcoming, changed: [M3-7524] - Add child_account OAuth scope to Create and View PAT drawers
Dec 19, 2023
mjac0bs
changed the title
upcoming, changed: [M3-7524] - Add child_account OAuth scope to Create and View PAT drawers
upcoming, change: [M3-7524] - Add child_account OAuth scope to Create and View PAT drawers
Dec 19, 2023
mjac0bs
added
Approved
Multiple approvals and ready to merge!
and removed
UX/UI
Changes for UI/UX to review
labels
Dec 20, 2023
This was referenced Jan 4, 2024
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
New Scope:
Introduce a new OAuth scope named "child_account" for all users, but visible only to "Parent" accounts. As per API spec: its purpose is to allow Parent Account Users with the
child_account_access
grant to specify a Token with less permission than their User, i.e. a Token that is unable to list and/or create Tokens for the Child Account(s).Token Configuration:
Default all scopes to
none
for users. Users should enable scopes as needed, contrary to having the initial state set toread_write
.Changes 🔄
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
yarn dev
.Verification steps
(How to verify changes)
serverHandler.ts
and edit the following request to change the user_type tonull
,child
, orproxy
:As an Author I have considered 🤔
Check all that apply