refactor: [M3-7547] - Graphs stories v7 migration #9999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
force-pushed
the
M3-7547
branch
from
10c1e1a to
bd04b23
Compare
abailly-akamai
changed the title
abailly-akamai
commented
Dec 14, 2023
| @@ -13,6 +13,7 @@ const config: StorybookConfig = { | |||
| '@storybook/addon-measure', | |||
| '@storybook/addon-actions', | |||
| 'storybook-dark-mode', | |||
| '@storybook/addon-storysource', | |||
There was a problem hiding this comment.
There is a code panel for stories in the documentation, but not for individual stories so this add-on helps with that
abailly-akamai
requested review from
carrillo-erik and
cliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
|
@bnussman-akamai yeah that's fair. I simplified the tests since they will go away for those specific components. |
coliu-akamai
approved these changes
Dec 18, 2023
| ariaLabel?: string; | ||
| /** | ||
| * The height in `px` of the chart\n`number`. |
There was a problem hiding this comment.
seeing a random \n appear in the documentation for this and some other props:
abailly-akamai
force-pushed
the
M3-7547
branch
from
3018cfd to
d76a2bc
Compare
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
PR to migrate our Graph stories to v7
Changes 🔄
7.6.4@storybook/addon-storysourceto show source code to individual storiesPreview 📷
How to test 🧪
Verification steps
(How to verify changes)
yarn storybookyarn test GaugePercent.test.tsxyarn test /LineGraph.test.tsxAs an Author I have considered 🤔
Check all that apply