generated from hashicorp/packer-plugin-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Replace test execution handler with conditional #232
Merged
ykim-akamai
merged 22 commits into
linode:dev
from
ykim-akamai:ci/replace_test_execution_handler_with_conditional
May 8, 2024
Merged
CI: Replace test execution handler with conditional #232
ykim-akamai
merged 22 commits into
linode:dev
from
ykim-akamai:ci/replace_test_execution_handler_with_conditional
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # builder/linode/config_test.go
ykim-akamai
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
May 8, 2024 17:17
lgarber-akamai
added
the
repo-ci-improvement
for improvements in the repository or CI workflow in the changelog.
label
May 8, 2024
lgarber-akamai
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
zliang-akamai
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Substitute hacky solution of executing integration tests and uploading test data with a more efficient solution using a conditional statement. This enhancement enables us to directly view test output within its associated step :)
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.