Perf opt

.github/workflows/kuttl-e2e-test-1.28.yaml

@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-go@v2
         with:
-          go-version: '1.20'
+          go-version: '1.21'
       - name: Install dependencies
         run: |
           sudo curl -Lo $KUTTL https://github.com/kudobuilder/kuttl/releases/download/v0.13.0/kubectl-kuttl_0.13.0_linux_x86_64

.husky/hooks/pre-push

@@ -13,7 +13,7 @@ if git status --short | grep -qv "??"; then
     trap unstash EXIT
 fi
 
-make generate
+make generate generate-pkg generate-tests
 git diff --exit-code --quiet || (git status && exit 1)
 
 make lint go.test.unit

Makefile

@@ -118,8 +118,10 @@ run: go.build
 # Create k8s service to allows pods to communicate with
 # localstack.
 cluster: $(KIND) $(KUBECTL) cluster-clean
+	docker pull localstack/localstack:2.2
 	@$(INFO) Creating kind cluster
 	@$(KIND) create cluster --name=$(KIND_CLUSTER_NAME) --config e2e/kind/kind-config-$(LATEST_KUBE_VERSION).yaml
+	@$(KIND) load docker-image --name=$(KIND_CLUSTER_NAME) localstack/localstack:2.2
 	@$(OK) Creating kind cluster
 
 # Spin up a Kind cluster and localstack and install Crossplane via Helm.

e2e/kuttl/ceph/provider-ceph-1.25.yaml

@@ -6,6 +6,4 @@ testDirs:
 kindConfig: e2e/kind/kind-config-1.25.yaml
 startKIND: false
 kindNodeCache: true
-kindContainers:
-- localstack/localstack:2.2
 timeout: 120

e2e/kuttl/ceph/provider-ceph-1.26.yaml

@@ -6,6 +6,4 @@ testDirs:
 kindConfig: e2e/kind/kind-config-1.26.yaml
 startKIND: false
 kindNodeCache: true
-kindContainers:
-- localstack/localstack:2.2
 timeout: 120

e2e/kuttl/ceph/provider-ceph-1.27.yaml

@@ -6,6 +6,4 @@ testDirs:
 kindConfig: e2e/kind/kind-config-1.27.yaml
 startKIND: false
 kindNodeCache: true
-kindContainers:
-- localstack/localstack:2.2
 timeout: 120

e2e/kuttl/ceph/provider-ceph-1.28.yaml

@@ -6,6 +6,4 @@ testDirs:
 kindConfig: e2e/kind/kind-config-1.28.yaml
 startKIND: false
 kindNodeCache: true
-kindContainers:
-- localstack/localstack:2.2
 timeout: 120

hack/generate-tests.sh

@@ -82,8 +82,6 @@ testDirs:
 kindConfig: e2e/kind/kind-config-${major}.yaml
 startKIND: false
 kindNodeCache: true
-kindContainers:
-- localstack/localstack:2.2
 timeout: 120
 EOF
 

internal/controller/bucket/create.go

@@ -69,6 +69,8 @@ func (c *external) Create(ctx context.Context, mg resource.Managed) (managed.Ext
 
 		pc := &apisv1alpha1.ProviderConfig{}
 		if err := c.kubeClient.Get(ctx, types.NamespacedName{Name: beName}, pc); err != nil {
+			c.log.Info("Failed to fetch provider config", "backend name", beName, "bucket_name", originalBucket.Name, "err", err.Error())
+
 			return managed.ExternalCreation{}, errors.Wrap(err, errGetPC)
 		}
 
@@ -94,7 +96,7 @@ func (c *external) Create(ctx context.Context, mg resource.Managed) (managed.Ext
 			}
 
 			if err != nil {
-				c.log.Info("Failed to create bucket on backend", "backend name", beName, "bucket_name", originalBucket.Name)
+				c.log.Info("Failed to create bucket on backend", "backend name", beName, "bucket_name", originalBucket.Name, "err", err.Error())
 
 				errChan <- err
 
@@ -160,7 +162,7 @@ WAIT:
 			errorsLeft--
 
 			if err != nil {
-				c.log.Info("Failed to create on backend", "bucket_name", bucket.Name)
+				c.log.Info("Failed to create on backend", "bucket_name", bucket.Name, "err", err.Error())
 
 				if errorsLeft > 0 {
 					continue