Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added lower level S3 calls and tidy ups #112

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Added lower level S3 calls and tidy ups #112

merged 6 commits into from
Dec 7, 2023

Conversation

nolancon
Copy link
Collaborator

@nolancon nolancon commented Dec 7, 2023 •
edited
Loading

Description of your changes

  • Added low level S3 API calls for Objects with wrapped errors at source.
  • Re-organised internal s3 package into separate files.
  • Removed duplicated funcs in health check controller
  • Added some test cases to health check controller

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Existing CI plus added test cases

@nolancon nolancon requested review from mhmxs and Shunpoco December 7, 2023 11:19
mhmxs
mhmxs approved these changes Dec 7, 2023
View reviewed changes
internal/s3/lifecycleconfig_helpers.go Outdated Show resolved Hide resolved
@nolancon nolancon merged commit dac085b into main Dec 7, 2023
9 checks passed
@nolancon nolancon deleted the low-level-api-calls branch December 7, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmxs mhmxs mhmxs approved these changes

@Shunpoco Shunpoco Awaiting requested review from Shunpoco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolancon @mhmxs