Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in create #118

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix NPE in create #118

merged 1 commit into from
Dec 13, 2023

Conversation

nolancon
Copy link
Collaborator

@nolancon nolancon commented Dec 13, 2023 •
edited
Loading

Description of your changes

errChan does not always return an error, sometimes its value is nil so we need to check it before setting trace.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@nolancon nolancon marked this pull request as ready for review December 13, 2023 11:48
@nolancon nolancon merged commit 40013db into main Dec 13, 2023
9 checks passed
@nolancon nolancon deleted the fix-npe branch December 13, 2023 11:53
@github-actions github-actions bot mentioned this pull request Dec 13, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-v0.0.28:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mojachieee Mojachieee Mojachieee approved these changes

Assignees
No one assigned
Labels
backport release-v0.0.28
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolancon @Mojachieee