Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autopause docs #276

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Update autopause docs #276

merged 2 commits into from
Jul 5, 2024

Conversation

nolancon
Copy link
Collaborator

@nolancon nolancon commented Jul 3, 2024

Description of your changes

Update to documentation (explains use of pause label instead of annotation)

I have:

  • Run make reviewable to ensure this PR is ready for review.
  • Run make ceph-chainsaw to validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. See docs/TESTING.md for information on how to run tests against a Ceph cluster.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@nolancon nolancon marked this pull request as ready for review July 3, 2024 12:13
@nolancon nolancon requested review from mhmxs and Shunpoco July 3, 2024 12:13
@nolancon nolancon merged commit 05e51c0 into main Jul 5, 2024
10 checks passed
@nolancon nolancon deleted the update-autopause-doc branch July 5, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants