Refactor/merge errors with tag #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix500526
force-pushed
the
refactor/MergeErrorsWithTag
branch
3 times, most recently
from
c74fbf6
to
2013e22
Compare
added 2 commits
January 20, 2024 21:47
Signed-off-by: Jiawei Zhao <Phoenxi500526@163.com>
Signed-off-by: Jiawei Zhao <Phoenxi500526@163.com>
Phoenix500526
force-pushed
the
refactor/MergeErrorsWithTag
branch
from
2013e22
to
74224d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the method
MergeErrorsWithTagis only used inAsResultand it seems unnecessary. I add an unit test to cover theAsResultmethod and refactor it. Based on pr #40