Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds output feedback when creating TODOs #67

Merged
merged 7 commits into from
Jan 15, 2021
Merged

Adds output feedback when creating TODOs #67

merged 7 commits into from
Jan 15, 2021

Conversation

scalvert
Copy link
Collaborator

Resolves #66

When using TODO_DAYS_TO_WARN or TODO_DAYS_TO_ERROR without UPDATE_TODO, it prints the following error:

You must use UPDATE_TODO when using any of TODO_DAYS_TO_WARN or TODO_DAYS_TO_ERROR.
When new todos are created:

✔ 1 todos created

When new todo created with warn days:

✔ 1 todos created (warn after 10 days)

When new todo created with error days:

✔ 1 todos created (error after 10 days)

When new todo created with warn and error days:

✔ 1 todos created (warn after 5 and error after 10 days)

@scalvert scalvert requested review from renatoi and rwjblue January 15, 2021 21:14
Copy link
Collaborator

@renatoi renatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scalvert scalvert merged commit 1c58b0f into main Jan 15, 2021
@scalvert scalvert deleted the todo-messages branch January 15, 2021 22:50
@scalvert scalvert added the enhancement New feature or request label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Todo usage messaging UX
2 participants