Cbor format #48
Open
Cbor format #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parser; CBOR needs a byte target, so we need our own open/close; remind Jackson not to close the stream for us. Confirmed working on a set of 20 tweet ids, reading the output with other CBOR tools.
CBOR work elsewhere.
output both the HTML and the JSON for completeness.
|
I've updated this pull request. The current code has been fully tested and generates output that is compatible with what we need for the DD track. Jimmy, did you want to review before I merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the twittertools crawler to be able to output multiple formats. Well, I need to add support for outputting CBOR.
I'm not proud of this patch, but just can't get up the gumption to design something better... every time I try to type 'CrawlerOutputFormatFactory' my brain seizes up and I go read Twitter. So I'm submitting this pull request mostly in hopes that someone will be affronted enough to write it nicer. But if not please pull this.