plugin/ocp_fid_c6h:Added the ocp C6h feature api #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed-by: Karthik Balan karthik.b82@samsung.com, Arunpandian J arun.j@samsung.com Signed-off-by: Vigneshwaran Saravanan/SSD TS Dev /SSIR/Engineer/Samsung Electronics <s.vignesh@samsung.com>
ikegami-t
reviewed
Oct 23, 2023
plugins/ocp/ocp-nvme.c
Outdated
| static int set_plp_health_check_interval(int argc, char **argv, struct command *cmd, | ||
| struct plugin *plugin) | ||
| { | ||
| const char *desc = "Define Issue Set Feature command (FID : 0xC2) PLP Health Check Interval"; |
There was a problem hiding this comment.
The indentations should be fixed and also please refer the commit messages PR comments below to check patch.
There was a problem hiding this comment.
Yes, you can use checkpatch.pl from the Linux project to figure out the obvious style problems:
$ ~/work/linux/scripts/checkpatch.pl -g HEAD
WARNING: Missing commit description - Add an appropriate one
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
ERROR: trailing whitespace
#95: FILE: Documentation/nvme-ocp-set-plp-health-check-interval.txt:11:
+'nvme ocp set-plp-health-check-interval' <device> [--plp_health_interval=<plp_health_interval> | -p <plp_health_interval>] [--save | -s] [--no-uuid | -n] $
ERROR: code indent should use tabs where possible
#153: FILE: plugins/ocp/ocp-nvme.c:1970:
+ struct plugin *plugin)$
WARNING: please, no spaces at the start of a line
#153: FILE: plugins/ocp/ocp-nvme.c:1970:
+ struct plugin *plugin)$
WARNING: please, no spaces at the start of a line
#155: FILE: plugins/ocp/ocp-nvme.c:1972:
+ const char *desc = "Define Issue Set Feature command (FID : 0xC2) PLP Health Check Interval";$FWIW, we just added a checkpatch.pl github workflow check to libnvme. I suppose we should also
add this to nvme-cli soon. I just want to see how it work in libnvme first.
There was a problem hiding this comment.
Incorporated the review comments
Reviewed-by: Karthik Balan karthik.b82@samsung.com, Arunpandian J arun.j@samsung.com Signed-off-by: Vigneshwaran Saravanan/SSD TS Dev /SSIR/Engineer/Samsung Electronics <s.vignesh@samsung.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ocp C6h feature api.
Reviewed-by: Karthik Balan karthik.b82@samsung.com, Arunpandian J arun.j@samsung.com
Signed-off-by: Vigneshwaran Saravanan/SSD TS Dev /SSIR/Engineer/Samsung Electronics s.vignesh@samsung.com