Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for codeql sweeps #2101

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

AM-K-19
Copy link
Contributor

@AM-K-19 AM-K-19 commented Oct 25, 2023

Add codeql.yml configuration file to allow routine static and vulnerability checks. By the way, codeql has detected one issue on the current head of master. I can provide additional details if required.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@igaw igaw merged commit 7e2d5b3 into linux-nvme:master Nov 2, 2023
15 checks passed
@igaw
Copy link
Collaborator

igaw commented Nov 2, 2023

Thanks! Let's see how this goes.

@igaw
Copy link
Collaborator

igaw commented Nov 3, 2023

I see a warning reported:

Could not process some files due to syntax errors
[View file](https://github.com/linux-nvme/nvme-cli/blob/master//home/runner/work/nvme-cli/nvme-cli/subprojects/libnvme/libnvme/__init__.py#L1-L1)

A parse error occurred while processing /home/runner/work/nvme-cli/nvme-cli/subprojects/libnvme/libnvme/\_\_init\_\_.py, and as a result this file could not be analyzed. Check the syntax of the file using the python -m py\_compile command and correct any invalid syntax.

@igaw
Copy link
Collaborator

igaw commented Nov 3, 2023

We should probably exclude the subprojects from the scan.

@AM-K-19
Copy link
Contributor Author

AM-K-19 commented Nov 5, 2023

We should probably exclude the subprojects from the scan.

Yes, that sounds sensible. Leave it with me. I'll try to figure out how to exclude such directories from the scan.

@AM-K-19
Copy link
Contributor Author

AM-K-19 commented Nov 6, 2023

I've created this new pull request:
#2115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants