Refactor and extend logging #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch the new low level passthru functions. Signed-off-by: Daniel Wagner <dwagner@suse.de>
There is no user for current_index, thus remove it Signed-off-by: Daniel Wagner <dwagner@suse.de>
This header file is not a local header file, it's the main header from libnvme. Thus use the correct include statement. Signed-off-by: Daniel Wagner <dwagner@suse.de>
In preparation to extend the logging use case move the existing code to a new location. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Preparation patch to enable verbose/debug logging in parts where we don't have the nvme_root_t object introduce a global logging level variable. Signed-off-by: Daniel Wagner <dwagner@suse.de>
The command line option parser is able to count how many times 'verbose' is provided by the user. This increases the verbosity level. Use this for mapping it to the correct log_level. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Instead pushing insane logging infra code into the library, let's keep this stuff in the frontend. This is done by providing our own version of the low level ioctl function as the library is exposing this as weak symbol. This allows us to print the passthru structures and also the timing information. Signed-off-by: Daniel Wagner <dwagner@suse.de>
tbzatek
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a global log level which then can be forwarded to libnvme. Also provide our own low level passthru commands so that we extend it with extensive logging outputs. While it also support the 64 bit version of it.