nbft: Discovery support #2315
Merged
nbft: Discovery support #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2024
tbzatek
force-pushed
the
nbft-discovery-2
branch
2 times, most recently
from
67f8d43 to
0891f22
Compare
Needed for nbft, useful to have public. Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
libnvme cleanup definitions are not part of public API. Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
This adds actual discovery support for Discovery Descriptor records. SSNS records are connected first. Discovery Descriptor records are checked for any existing (back-)reference from SSNS records and are skipped if so. It is assumed in such case that the pre-OS driver has succeeded in discovery and filled SSNS records accordingly. In case no SSNS record references the particular Discovery record, an actual discovery is performed. Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
Depending on a pre-OS implementation, boot attempts pointing to the well-known discovery NQN may get transformed in an SSNS record (and marked as 'unavailable') in case the discovery cannot be performed. Otherwise the NBFT table should be populated by discovered records instead. Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
Attempt to look up and use existing (persistent) discovery controller. Signed-off-by: Tomas Bzatek <tbzatek@redhat.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings support for performing discovery and connect-all from Discovery Descriptor List records.
Needs linux-nvme/libnvme#820 to parse URIs from NBFT.
Tested with static IPv4 and IPv6 against linux soft target.
For now, persistent discovery controllers have not been tested.