Fixed the issue of response handling errors when program key multiple… #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Feb 19, 2025
| if (err != 0) | ||
| fprintf(stderr, "Program Key recv error = 0x%x\n", err); | ||
| else | ||
| err = check_rpmb_response(req, rsp, "Failed to Program Key"); | ||
| out: |
There was a problem hiding this comment.
Please follow the style from above, test for error print warning bail out. Also check the coding style. The commit message needs also more attention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing the key multiple times, the error logs cannot indicate that the key writing has failed. Fixed the issue of response handling errors at this commit.