nvme-stas 2.3-rc6 #392
Merged
nvme-stas 2.3-rc6 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2023 09:22
We found that SFSS advertises (mDNS) its services before it is even listening for connections. If a host responds too quickly to Avahi detection of the CDC and tries to connect before the CDC is actually listening, we will get the connection refused error. SFSS should only advertise its service with mDNS when it is ready to receive connections. However, nvme-stas will now have a retry mechanism in case SFSS cannot fix this issue. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 58.73% 58.01% -0.73%
==========================================
Files 16 16
Lines 2603 2627 +24
==========================================
- Hits 1529 1524 -5
- Misses 1074 1103 +29
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retries on connectivity checks.