Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message in mlx5 verbs #1465

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

DanCh2020
Copy link
Contributor

No description provided.

@rleon
Copy link
Member

rleon commented Jun 3, 2024

Hi,

in rdma-core, we follow kernel coding style and require Signed-off-by: ... tag.
Please add it together with more elaborated commit message.

Thanks

@nmorey
Copy link
Contributor

nmorey commented Jun 3, 2024

Please also add a 'Fixes' tag to your commit message mark which commit introduced the bug.
In this case:
Fixes: 0c7ac1083831 ("Add XRC support")

The error message contains incorrect information about the error cause

Fixes: 0c7ac10 ("Add XRC support")
Signed-off-by: Danila Chernetsov <listdansp@mail.ru>
@DanCh2020
Copy link
Contributor Author

Hi,
thank you for you suggestions.
Fixed and pushed

@yishaih yishaih merged commit 4b42924 into linux-rdma:master Jun 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants