Fix for cm_svc_run #1484
Merged
Fix for cm_svc_run #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleon
reviewed
Jul 24, 2024
| cm_svc_process_sock(svc); | ||
| /* svc->contexts will be changed, so need to assign again */ | ||
| fds = svc->contexts; |
There was a problem hiding this comment.
nit: I would say 'svc->contexts may have been reallocated' rather than 'will be changed' Fix looks good.
linxiaochou
force-pushed
the
fix-cm_svc_run
branch
from
eeff9f8
to
c5abe17
Compare
|
@rleon I'm glad you responded and pointed out my problem. I've updated the commit msg. Hope it works this time. |
When the cm_svc_run thread starts, svc->contexts will be initialized with four elements. When reallocating memory due to an increased element count, svc->contexts will point to new addresses, whereas the fds variable in the cm_svc_run thread is free of the address, which will result in subsequent cm_svc_run threads running incorrectly. So we need to update the fds variable every time the cm_svc_process_sock function is processed. Fixes: b60c79d ("rsockets: Use service thread to accept connections") Signed-off-by: linxiaochou <929331108@qq.com>
linxiaochou
force-pushed
the
fix-cm_svc_run
branch
from
c5abe17
to
24061f0
Compare
|
@shefty Thank you for your reply and suggestions. I have already revised the corresponding notes. Hope it can work this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cm_svc_run thread starts, the four element size rss will be allocated to svc->contexts. When the rss reallocates memory due to an increase in the number of elements in the cm_svc_process_sock function, the rss will point to a new address, but the cm_svc_run function does not get the new address again, leading to an exception in the future