v4.19: pwm: lpss: Add ACPI HID for second PWM controller on Cherry Trail devices

[kitakar5525]

(patch for 4.19 branch)

cherry-picked a commit from newer kernel hoping that this patch improves battery life on Surface 3.

Surface 3 can achieve S0ix without this commit on v4.19 kernels anyway but the second PWM controller actually exists on Surface 3 according to acpidump.
Applying this patch does no harm. So, let's apply this patch anyway hoping longer battery life?

If you don't want to add patches unnecessarily, I can test battery life before merging this patch...

---

The second PWM controller on Cherry Trail devices uses a separate ACPI
HID: "80862289", add this so that the driver will properly bind to the
second PWM controller.

The second PWM controller is usually not used, the main thing gained by
this is properly putting the PWM controller in D3 on suspend.

Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Signed-off-by: Hans de Goede hdegoede@redhat.com
Signed-off-by: Thierry Reding thierry.reding@gmail.com

(cherry picked from commit 1688c87)
[Reason for cherry-picking this commit:
to try to improve S0ix on Cherry Trail devices such as Surface 3 on
kernels below v4.20-rc1.

TODO: Surface 3 can achieve S0ix without this commit on v4.19 kernels
anyway but the second PWM controller actually exists on Surface 3
according to acpidump. How does this commit improve S0ix on
Surface 3 regarding battery life?]
Signed-off-by: Tsuchiya Yuto (kitakar5525) kitakar@gmail.com

[kitakar5525]

oh, if necessary, I can prefix "S0ix" or "suspend" or something before the original commit title.

[kitakar5525]

Ah, sorry. I've re-read bugzilla [1] and turned out that I've been misunderstanding.

Yes, there is actually the second PWM controller but the HID on Surface 3 is 80862288 that is the same as the first PWM controller (and this id is indeed already added). So, no need to apply this patch for Surface 3. Closing this PR.

DSDT excerpt on "Asus E200HA" and "HP x2 210":

        Device (PWM1)
        {
            Name (_HID, "80862288")  // _HID: Hardware ID
            Name (_CID, "80862288")  // _CID: Compatible ID
            Name (_DDN, "Intel(R) PWM Controller #1 - 80862288")  // _DDN: DOS Device Name
[...]
        Device (PWM2)
        {
            Name (_HID, "80862289")  // _HID: Hardware ID
            Name (_CID, "80862289")  // _CID: Compatible ID
            Name (_DDN, "Intel(R) PWM Controller #2 - 80862289")  // _DDN: DOS Device Name

On the other hand, Surface 3:

        Device (PWM1)
        {
            Name (_HID, "80862288")  // _HID: Hardware ID
            Name (_CID, "80862288")  // _CID: Compatible ID
            Name (_DDN, "Intel(R) PWM Controller #1 - 80862288")  // _DDN: DOS Device Name
[...]
        Device (PWM2)
        {
            Name (_HID, "80862288")  // _HID: Hardware ID
            Name (_CID, "80862288")  // _CID: Compatible ID
            Name (_DDN, "Intel(R) PWM Controller #2 - 80862289")  // _DDN: DOS Device Name

[1] https://bugzilla.kernel.org/show_bug.cgi?id=196861
("Bug 196861 - S0ix enablement - Asus E200HA (Atom x5-Z8300, Cherrytrail)")