Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix python unit test - copy pytest config to tests/unit #147

Merged
merged 1 commit into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. ci: fix python unit test - copy pytest config to tests/unit

    This is fixed by tox-lsr 3.2.2 - all actions that use tox-lsr are updated to
    3.2.2, not just the python unit tests, even though the fix is only related to
    pytest.  All roles are updated to use tox-lsr 3.2.2 for the sake of consistency
    even if not affected by the pytest issue.
    
    Something changed recently in the way github actions provisions systems which
    means some of the directories are not readable by the python unit test actions.
    In addition, the python unit tests were causing a lot of unnecessary directory
    traversal doing collection/discovery of unit test files, because of using
    `pytest -c /path/to/tox-lsr/pytest.ini` Unfortunately, with `pytest`, the
    directory of the config file is the root directory for the tests and tests
    discovery, and there is no way around this.
    
    Therefore, the only solution is to copy the tox-lsr `pytest.ini` to the
    `tests/unit` directory, which makes that the test root directory.
    
    See also linux-system-roles/tox-lsr#160
    
    Signed-off-by: Rich Megginson <rmeggins@redhat.com>
    richm committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    abc2b43 View commit details
    Browse the repository at this point in the history