Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add libblockdev-nvme to blivet dependencies on RHEL/CentOS 9 #383

Conversation

vojtechtrefny
Copy link
Collaborator

@vojtechtrefny vojtechtrefny commented Sep 25, 2023

On RHEL blivet now also uses libblockdev NVMe plugin so we should
add it as a dependency here as well.

Fixes: #382

On RHEL blivet now also uses libblockdev NVMe plugin so we should
add it as a dependency here as well.

Fixes: linux-system-roles#382
@vojtechtrefny vojtechtrefny changed the title Add libblockdev-nvme to blivet dependencies on RHEL/CentOS 9 fix: Add libblockdev-nvme to blivet dependencies on RHEL/CentOS 9 Sep 25, 2023
@spetrosi
Copy link
Contributor

[citest]

@richm
Copy link
Contributor

richm commented Sep 25, 2023

Do we need a list of packages in vars/ files at all, for any platform? Doesn't blivet dynamically generate the list of packages to be installed?

@vojtechtrefny
Copy link
Collaborator Author

Do we need a list of packages in vars/ files at all, for any platform? Doesn't blivet dynamically generate the list of packages to be installed?

Technically all dependencies of blivet are optional and it's up to the user to install all dependencies they need (we for example don't have libblockdev-loop here because the role doesn't support loop device management, but blivet does). I wouldn't be against just requiring everything in blivet, but we had lot of issues from people complaining about too many dependencies that are not needed.

libblockdev-nvme is not needed for working with NVMe drives (we need it just to gather some extra information about the namespace and for NVMe over Fabrics support, we can use NVMes without it) so we could just not include the dependency and ignore the warnings if we are ok with that.

@richm
Copy link
Contributor

richm commented Sep 26, 2023

Do we need a list of packages in vars/ files at all, for any platform? Doesn't blivet dynamically generate the list of packages to be installed?

Technically all dependencies of blivet are optional and it's up to the user to install all dependencies they need (we for example don't have libblockdev-loop here because the role doesn't support loop device management, but blivet does). I wouldn't be against just requiring everything in blivet, but we had lot of issues from people complaining about too many dependencies that are not needed.

libblockdev-nvme is not needed for working with NVMe drives (we need it just to gather some extra information about the namespace and for NVMe over Fabrics support, we can use NVMes without it) so we could just not include the dependency and ignore the warnings if we are ok with that.

Fine with me - but can we somehow suppress the WARNING and CRITICAL errors? Many times we have storage role issues, and the very first thing the user sees is the WARNING and CRITICAL which leads the user on the wrong path - these messages just add noise and make debugging more difficult.

@richm richm closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required package libblockdev-nvme not installed on EL9
3 participants