test: lsblk can return LOG_SEC or LOG-SEC #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_unused_disk is broken on some systems because `lsblk ... LOG-SEC` can return `LOG_SEC` with an underscore instead of the requested `LOG-SEC` with a dash.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
- Coverage 16.54% 11.68% -4.87%
==========================================
Files 2 8 +6
Lines 284 1780 +1496
Branches 79 0 -79
==========================================
+ Hits 47 208 +161
- Misses 237 1572 +1335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_unused_disk is broken on some systems because
lsblk ... LOG-SECcanreturn
LOG_SECwith an underscore instead of the requestedLOG-SECwith a dash.