pytest: Create xml coverage report for codecov #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the XML coverage report since this is the one that is needed for codecov. Note: codecov uses some heuristics to find the coverage file and it does not seem to be possible to specify which file to use. The get_coverage.yml playbook is also wrongly identified as a coverage report which can be confusing if the actual report is not identified as one. Signed-off-by: Till Maas <opensource@till.name>
|
FYI: The github workflow also needs to be updated: linux-system-roles/.github#11 |
richm
approved these changes
Feb 10, 2023
richm
pushed a commit
to richm/tox-lsr
that referenced
this pull request
Feb 10, 2023
Create the XML coverage report since this is the one that is needed for codecov. Note: codecov uses some heuristics to find the coverage file and it does not seem to be possible to specify which file to use. The get_coverage.yml playbook is also wrongly identified as a coverage report which can be confusing if the actual report is not identified as one. Signed-off-by: Till Maas <opensource@till.name> (cherry picked from commit ab14427)
richm
added a commit
that referenced
this pull request
Feb 10, 2023
* fix python black issue (#108) (cherry picked from commit 558c7f7) * pytest: Create xml coverage report for codecov (#109) Create the XML coverage report since this is the one that is needed for codecov. Note: codecov uses some heuristics to find the coverage file and it does not seem to be possible to specify which file to use. The get_coverage.yml playbook is also wrongly identified as a coverage report which can be confusing if the actual report is not identified as one. Signed-off-by: Till Maas <opensource@till.name> (cherry picked from commit ab14427) * add safety suppressions --------- Co-authored-by: Till Maas <opensource@till.name>
richm
added a commit
to richm/linux-system-roles-network
that referenced
this pull request
Feb 10, 2023
Use tox-lsr version 2.13.2 in order to pick up the codecov fix. linux-system-roles/tox-lsr#109 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
tyll
pushed a commit
to linux-system-roles/network
that referenced
this pull request
Feb 11, 2023
Use tox-lsr version 2.13.2 in order to pick up the codecov fix. linux-system-roles/tox-lsr#109 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the XML coverage report since this is the one that is needed for codecov.
Note: codecov uses some heuristics to find the coverage file and it does not seem to be possible to specify which file to use. The get_coverage.yml playbook is also wrongly identified as a coverage report which can be confusing if the actual report is not identified as one.
Signed-off-by: Till Maas opensource@till.name
https://app.codecov.io/github/linux-system-roles/network/commit/4a5122e94ca922813c7eadfd19568b338794b023 contains a successful run for the Python 3.11 job for reference.
Btw. maybe the coveralls support can be dropped from tox_lsr, not sure if anyone else is using it.
Remark: The current codecov reports seem to be only based on the ansible-test job results and are therefore very basic.