container improvements #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richm
commented
Jun 28, 2023
richm
commented
- Many improvements, docs for running tests in containers.
- Add 2 options to runcontainer.sh (Initial project setup #1)
- ci: manually install python 2.7
- ignore vulnerability - does not affect
- fix some coding, shellcheck issues
nhosoi
reviewed
Jun 29, 2023
README.md
Outdated
| * `--log-dir PATH` - When using `--parallel` - for each test playbook named `TESTNAME.yml` | ||
| the log will be written to a file named `TESTNAME.log` in the `PATH` directory. | ||
| The default is the directory where `TESTNAME.yml` is found. | ||
| * `--fail-fast true|false` - default `false`, which means all of the tests will be run |
See the README e.g. `tox -e container-ansible-core-2.15 -- --image-name centos-9 tests/tests_default.yml` Signed-off-by: Rich Megginson <rmeggins@redhat.com>
- --extra-rpm <RPM>: specifies an additional rpm package to install
in the container. Default to none. E.g.,
--extra-rpm diffutils --extra-rpm sudo
- --extra-skip-tag <TAG>: specifies a tag to skip. Default to none.
E.g., --extra-skip-tag "tests::use_selinux_role"
If no `--parallel` option is given, it runs all the tests in one
ansible-playbook command line that is the original behavior.
If `--parallel` option is given, it runs each test per command
line. To run *.yml per command line in one container, '--parallel 1`
option is required.
richm
force-pushed
the
container-improvements
branch
from
21f0018
to
01186f9
Compare
nhosoi
reviewed
Jun 29, 2023
| sequentially. | ||
| * `--log-dir PATH` - When using `--parallel` - for each test playbook named `TESTNAME.yml` | ||
| the log will be written to a file named `TESTNAME.log` in the `PATH` directory. | ||
| The default is the directory where `TESTNAME.yml` is found. |
There was a problem hiding this comment.
May I add the description for the new options --extra-rpm and --extra-skip-tag here?
- --extra-rpm : specifies an additional rpm package to install
in the container. Default to none. E.g.,
--extra-rpm diffutils --extra-rpm sudo - --extra-skip-tag : specifies a tag to skip. Default to none.
E.g., --extra-skip-tag "tests::use_selinux_role"
richm
force-pushed
the
container-improvements
branch
from
01186f9
to
56b9ae2
Compare
nhosoi
approved these changes
Jun 29, 2023
Thanks - have you tried this new version? If so thanks - if not, I'd rather not merge it unless it works for you |
I reran this command line and it passed successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.