Change theme for easier navigation #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love it. @osresearch ? |
|
Love the ordering. All links on generated pages points correctly to rendered .md pages. |
|
@tlaurion @osresearch I should have mentioned that. This also contains fixes mentioned in #38. The ordering is the same as that on the index page. This is mainly to be a functional change (add site navigation and search). If this is approved, I will continue with breaking down certain pages into subsections, group other pages. Obviously, changes like that will require more scrutiny but does not make much sense with the current theme's navigation. |
|
LGTM |
Closed
|
Looks wonderful and very readable. +1 from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo of changes can be viewed here: https://thrilleratplay.github.io/heads-wiki/
This is an attempt to create smaller incremental changes I mentioned in a comment in #25 .