Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaned up PR for adding w530 boards (from #1059) separating the w530 from t520 and t530 for clarity and ease of merging. Boards for flash, maximized and hotp-maximized have been added. I am not intending to support non-maximized boards. Tested and working. All w530 have dGPUs. Coreboot does not initialize the dGPU using these configs. I do not intend to add support for initializing the dGPU at this stage (it will require some changes to the config file and addition of blobs in the blob directory) but will if there is community demand (see #1065).
Boards currently point to Coreboot 4.13, but 4.14 also tested and working. Support for the w530 was not added in coreboot until version 4.9 so it cannot be built using the current heads:master, which points to 4.8.1 for thinkpad boards.
Note: it can be tricky to properly read the 8MB chip on the T530 and W530 (see #996). This appears to be because the two chips share a power source on these boards (see generally). This is true for both the Rasbperry Pi and the CH431a. There appears to be two workarounds: (1) the Wake on Lan method (which has the one downside of only working once, because it is not supported by coreboot and is, therefore, not available after flashing); or (2) keeping the CMOS battery plugged in, which works also post-flashing. Both methods provide a little extra power to the board and appear to then be sufficient to get enough power to the 8MB chip to get a proper read of it. The Skulls team generally suggest using an external power source with the CH341a, and it's possible that this might help, but I have not tested