Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current builds (zlib 1.2.11 cannot be downloaded, busybox patch not applied) #1144

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Apr 1, 2022

  • zlib 1.2.12 release is not respecting cross compiling. We save current builds with old zlib.
    • 1.2.11 disappeared from servers: taking another archive link, same hash.
  • busybox 1.32.0 was not patched with 1.28.0 patch. Renaming patch so that its applied in fresh builds.

- zlib 1.2.12 release is not respecting cross compiling. 1.2.11 disappeared from servers: taking another archive link, same hash.
- busybox 1.32.0 was not patched with 1.28.0 patch. Renaming patch so that its applied in fresh builds.
@tlaurion tlaurion force-pushed the fix_busybox_zlib_current_build branch from ff738b6 to 981cb96 Compare April 1, 2022 13:47
@tlaurion
Copy link
Collaborator Author

tlaurion commented Apr 1, 2022

@MrChromebox @osresearch : please approve.

We would need a release and downloadable roms with the result of this merged commit, prior of thinking of moving out of the current buildsystem and replace it with https://github.com/osresearch/linux-builder (which is a PoC now, but fixed all reproducibility issues 👍 !)

@MrChromebox
Copy link
Contributor

MrChromebox commented Apr 1, 2022

would you mind rewording the commit msg to something like modules/zlib: fix download URL to make it more obvious what the patch is doing? and then make the busybox patch rename a separate commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants