Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dgpu-t430 configs #1176

Closed
wants to merge 7 commits into from
Closed

merge dgpu-t430 configs #1176

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2022

sourced from eganonoa/heads and edited. conflicts should be resolved now

eganonoa and others added 6 commits December 29, 2021 00:26
Maximized boards being supported here only. I do not have a board to test. But these have been tested as working by another user (see #1057 (comment)).
Add support for t430 dgpu-versions
…for FL1 files only. Also add sudo calls where required

still need correct code in line 64
@tlaurion
Copy link
Collaborator

tlaurion commented Jun 17, 2022

@walliams ! Awesome, t430-dgpu owners will be happy (where documentation on disassembling and supported platforms is totally out of date (non-existing) in regard of t430 w530 t530 in wiki and users confused that only x230 i documented.)

I would love to see a at least a reference in the boards configs to the blobs required/included in the coreboot configurations, otherwise hidden under coreboot configuration file alone, also a pointer to the script that is required to be ran to have the blobs put in place, and a reference to the README in the blobs dir, even more if that needs to have nvramutil ran to configure things properly (might not be, i'm still not super knowledgeable about the dgpu requirements and mix dgpu requirements myself of the lately added dgpu boards)?

@walliams : since you are owner of all those boards, are you up to drafting some documentation updates, at least in regard to this t430-dgpu additional board support ? Last time I agreed for doc to follow board addition, that documentation..... never followed. And flows millions of questions from Heads community because doc is missing....

https://osresearch.net/Contributing-to-Heads-wiki/

Any suggestion welcome on that level. Documentation is a burden as of now. I don't seem to place myself properly as a non-technical user when producing doc content :|

Affected links:

@ghost
Copy link
Author

ghost commented Jun 17, 2022

happy to help with documentation on xx30-dgpu models as my next task. didn't notice that even the existing dgpu configs lack reference to vbios blob scripts... that could be improved. i can work on that as well.

also, any clue why the circleci check failed here? i didn't change anything related to the x230, though these boards do reference x230-hotp-maximized in .circleci/config.yml

@tlaurion
Copy link
Collaborator

tlaurion commented Jun 17, 2022

@walliams please rebase on master.... mbetls is not downloadable from its main website, the website is broken. I just merged the change so that download happens over githib instead.

CircleCI is failing for race conditions, I have to kick the builds on merging... This is annoying but will change when updating coreboot and linux kernels....

@tlaurion
Copy link
Collaborator

Houla.

git fetch master
git rebase master
git commit --amend

Should be an empty commit.
Otherwise we will have to rebase dynamically after, you should not merge master in your branch.

Now we have an undesired commit in this branch :/

@ghost
Copy link
Author

ghost commented Jun 18, 2022

o darn. sry i'm new to this. do i need to setup a github desktop cli or something

@ghost
Copy link
Author

ghost commented Jun 18, 2022

i can just close this and redo my branch. i don't want to create any more work for anyone else

@tlaurion
Copy link
Collaborator

git fetch master
git rebase master
git commit --amend

Those are from command line?

@ghost
Copy link
Author

ghost commented Jun 18, 2022

i'm just confused about doing this from cli... i forked the repo and edited this all in browser.

@ghost
Copy link
Author

ghost commented Jun 18, 2022

just github.com web interface, via firefox. is this something i can do here, or do i need to clone to a local repo and run commands?
or now that i accidentally merged master downstream is it too late or can i reverse the commit and rebase as you suggest? or better off just wiping my repo, rebuild starting from updated master and merge code from eganonoa again?

sorry. am git noob

@ghost
Copy link
Author

ghost commented Jun 18, 2022

i mean i build heads in a debian vm, with manually inserted code for the t430-dgpu, but my fork and PR here were all done on the web interface because the only git commands i know are clone and pull.

@ghost
Copy link
Author

ghost commented Jun 18, 2022

i'll just make a new PR once i figure out what i'm doing. thanks for the pointers

@ghost ghost closed this Jun 18, 2022
@tlaurion
Copy link
Collaborator

Well, I can quickly fix this, create a PR.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants