-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Librem image shrink #1232
Librem image shrink #1232
Conversation
…at for CircleCI librem builds + review/testing
…at for CircleCI librem builds + review/testing - Put back @BLOB_DIR@
# CONFIG_SYSFS_DEPRECATED is not set | ||
CONFIG_RELAY=y | ||
CONFIG_BLK_DEV_INITRD=y | ||
CONFIG_INITRAMFS_SOURCE="../../../blobs/dev.cpio" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be CONFIG_INITRAMFS_SOURCE="@BLOB_DIR@/dev.cpio"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this one. Remained from Purism's Pureboot config
@Unb0rn replied to your questions under #1229 (comment) |
Hi @Unb0rn, thanks again for the work on this! Could you please split this up into a few commits so it is easier to review? I'd suggest one commit converting to full-config (with no other changes), and another commit making the config changes we want. Anything along those lines is more reviewable though, right now it is hard to see what exactly was changed (i.e. I think BTRFS was enabled here too, which isn't directly related). You can replace the existing config file, and then we'll get CI builds I can help test. Right now this doesn't affect anything because the Librem boards still reference the existing config. Regarding the specific configs in the description, I mentioned some of those in #1229 but didn't catch all of them:
|
9c361c7
to
8d3d8bf
Compare
@JonathonHall-Purism yeah, you were right. Updated defconfig just to build and test everything, removed BTRFS and exFAT as they're unrelated.
Do we need any of it in our minimal image? |
@Unb0rn I do not think so. @JonathonHall-Purism ? |
# under linux decompressed+patched directory and put it back in git tree | ||
# to check changes with git difftool | ||
# useful for development cycle of linux kernel version bumps. | ||
linux.modifydefconfig: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, I had been doing this manually!
Agree, I don't think we need any of those. |
Well, it looks I started celebrating a bit too early) |
…argets to help tweaking/version bumps
e22a530
to
cf79147
Compare
It turned out to be even more interesting - it had nothing to do with multiuser support, however flashrom still uses iopl() or ioperm(), so had to re-enable it. Double checked to be working. |
No IOMMU device isolation under Heads. |
|
@JonathonHall-Purism points addressed under #1232 (comment) to be dealt separately? |
Yeah, I think they should be addressed separately. This is a good improvement, it didn't introduce those issues, and I don't see any reason to hold it waiting for other improvements. Double checking that everything else has tracking issues:
|
OK! Note that dynamic debugging kernel options are removed from kernel from this point! Merging! |
This should resolve #1229
Tried not to break anything for any Librem machine, however I am able to test it only on Librem 14
Still need some input on some options:
The format is also switched to full config instead of defconfig