-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xx20/xx30 maximized coreboot configs: Fix CONFIG_CBFS_SIZE to reflect ifd.bin's BIOS region (xx20: gain of 0.59mb, xx30: gain of 0.4mb #1298
Conversation
Additional details: x230-hotp-maximized
4742872-4350168=392704 additional free bytes t420-hotp-maximized
622744-31384=591360 additional free bytes |
I have just flashed https://output.circle-artifacts.com/output/job/008109e7-ede2-4ed1-95bc-dd9f5117edfc/artifacts/0/build/x86/x220-maximized/heads-x220-maximized-v0.2.0-1358-gf07ef81.rom on my x220. Seems to work fine with no adverse effects. |
t420-hotp-maximized works great! |
I'll wait for a couple of days but since we have xx20 reports, I'm comfortable merging. |
f07ef81
to
72454ed
Compare
Rebased on #967
|
… ifd.bin's BIOS regions. The calculations outlined at linuxboot#1282 (comment) Sums to having 'ifdtool -f layout.txt ifd_shrinked.bin && cat layout.txt' The example for T440p: 00000000:00000fff fd 00021000:00bfffff bios 00003000:00020fff me 00001000:00002fff gbe Here: 00bfffff-00021000=BDEFFF Which is exact result of @rbeslow's calculations. There is an issue on haswell, maybe because of car, maybe because of non native memory init blob. But this is not the case for xx20/xx30 boards.
72454ed
to
e7f1e3e
Compare
The calculations outlined at #1282 (comment) sums to having 'ifdtool -f layout.txt ifd_shrinked.bin && cat layout.txt'
The content of layout.txt for T440p:
Here:
00bfffff-00021000=BDEFFF
BDEFFF to decimal = 12447743
Which is exact result of @rbeslow's calculations, and was recommended calculation for CBFS size (outside of bugs), otherwise setting it to 8mb.
There is an issue on haswell, maybe because of car, maybe because of non native memory init blob, but all of that is related to #1282, not here.
But this is not the case for xx20/xx30 boards which have native ram init (where t440p should see it hapenning under 4.19+)
Tested with this PR:
This would be free gain for #590!!!
This, if working for all boards with unlocked ifd (maximized builds), (truely) maximizes available space for Heads (CBFS), based on freed ME space relegated to BIOS region.
Now time to test other boards. Tagging people from #692 to test only if external programmer accessible: