Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump boards depending on coreboot 4.13 to 4.19 #1312

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Bump boards depending on coreboot 4.13 to 4.19 #1312

merged 1 commit into from
Apr 24, 2023

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Feb 15, 2023 •
edited
Loading

  • No important configuration changes, so reusing 4.13 coreboot configs
  • x230 FHD/EDP is the only board still needing patch on coreboot since https://review.coreboot.org/c/coreboot/+/28950 was not merged upstream under 4.19 in time for release
    • Upstream patch didn't apply cleanly on 4.19. Reported upstream in same merge request above.
  • coreboot 4.19 release tarballs were unusable until recreated yesterday since they contained invalid timestamps (https://ticket.coreboot.org/issues/456)

Note the further PRs are welcome to enable new security features:

  • Memory scrubbing on boot is possible for most platforms (no idea of added boot time, untested)
  • Etc...

Also note recent changes in master:

  • x230 and t430 legacy boards have been renamed as such for clarity
  • There is no need to duplicate coreboot configurations for a single board config unless additional coreboot options are defined (they can be shared across boards sharing the same coreboot config)

@tlaurion tlaurion marked this pull request as draft February 15, 2023 18:17
@tlaurion tlaurion mentioned this pull request Feb 15, 2023
Merged
5 tasks
@tlaurion
Copy link
Collaborator Author

tlaurion commented Feb 15, 2023 •
edited
Loading

Report:

  • x230-hotp-maximized works
    • resume from suspend works

Also tested #1063 as part of above test (local cherry-pick) without regression with Nitrokey Pro.

@tlaurion
Copy link
Collaborator Author

tlaurion commented Feb 15, 2023 •
edited
Loading

This is massive change (4.13 - > 4.19) without configuration change.
It was reported upstream that resume from suspend issues were present, where I just tested on x230 for x230-hotp-maximized and didn't saw any regression (but low testing).

Images produced in CircleCI build are based on master, so if you could report, as usual, at least one success per board, this would make merging upstream easier.

@tlaurion
Copy link
Collaborator Author

(your names have been added under #692)

Please confirm roms are functional for at least one of you.

@tlaurion
Copy link
Collaborator Author

Will force push (without changes observable between commits) so that WiP reflects current changes of single commit of this PR

@tlaurion tlaurion force-pushed the coreboot-4.13_coreboot-4.19_version_bump branch from 1112a58 to 5589657 Compare February 15, 2023 21:40
@tlaurion tlaurion changed the title WiP: Bump boards depending on coreboot 4.13 to 4.19 Bump boards depending on coreboot 4.13 to 4.19 Feb 15, 2023
@tlaurion tlaurion marked this pull request as ready for review February 15, 2023 21:40
@srgrint
Copy link
Contributor

srgrint commented Feb 15, 2023

Tested heads-x220-maximized-v0.2.0-1371-g5589657.rom. Seems to work fine including suspend/resume

tlaurion added a commit to tlaurion/heads that referenced this pull request Feb 17, 2023
@tlaurion
xx30 - TXT enablement requirements
9698489 
- As of now, includes download and extraction scripts under blobs/xx30/download_extract_acm.sh
- Adds x230-hotp-maximized-acm and x230-maximized-acm boards
- Based on top of both linuxboot#1312 and linuxboot#1172 (coreboot 4.19 based)

Next: attempt https://matrix.to/#/!WHWPvnIGPhGGtUFucJ:matrix.org/$qkNCHc4PDARgf_dLGZAVvYUF-eSgE5pLxL4DhgIW6i8?via=matrix.org&via=invisiblethingslab.com&via=matrix.tu-berlin.de
tlaurion added a commit to tlaurion/heads that referenced this pull request Feb 17, 2023
@tlaurion
xx30 - TXT enablement requirements
191a67d 
- As of now, includes download and extraction scripts under blobs/xx30/download_extract_acm.sh
- Adds x230-hotp-maximized-acm and x230-maximized-acm boards
- Based on top of both linuxboot#1312 and linuxboot#1172 (coreboot 4.19 based)

Next: attempt https://matrix.to/#/!WHWPvnIGPhGGtUFucJ:matrix.org/$qkNCHc4PDARgf_dLGZAVvYUF-eSgE5pLxL4DhgIW6i8?via=matrix.org&via=invisiblethingslab.com&via=matrix.tu-berlin.de
tlaurion added a commit to tlaurion/heads that referenced this pull request Feb 17, 2023
@tlaurion
xx30 - TXT enablement requirements
e5a799c 
- As of now, includes download and extraction scripts under blobs/xx30/download_extract_acm.sh
- Adds x230-hotp-maximized-acm and x230-maximized-acm boards
- Based on top of both linuxboot#1312 and linuxboot#1172 (coreboot 4.19 based)

Next: attempt https://matrix.to/#/!WHWPvnIGPhGGtUFucJ:matrix.org/$qkNCHc4PDARgf_dLGZAVvYUF-eSgE5pLxL4DhgIW6i8?via=matrix.org&via=invisiblethingslab.com&via=matrix.tu-berlin.de
@tlaurion tlaurion mentioned this pull request Feb 18, 2023
Closed
10 tasks
tlaurion added a commit to tlaurion/heads that referenced this pull request Feb 19, 2023
@tlaurion
Daily driver test fo x230-hotp-maximized on coreboot 4.19, with debug…
5605b76 
…, yubikey test regression for oem-factory-reset, optimized for space (03-O2->Os) and fix for sh: argument expected, with local CONFIG_DEBUG_OUTPUT enabled and fused in ROM.

Includes linuxboot#1317, linuxboot#1121, linuxboot#1312, linuxboot#1305 for test on daily driver
tlaurion added a commit to tlaurion/heads that referenced this pull request Feb 19, 2023
@tlaurion
Merge branch 'dasharo_flashrom_test' into O3-O2-to-Os_coreboot-4.19-f…
16de2e2 
…ix-sh_argument_expected-yubikey-oem-factory-reset_dasharo-flashrom

Daily driver test fo x230-hotp-maximized on coreboot 4.19, with debug, yubikey test regression for oem-factory-reset, optimized for space (03-O2->Os) and fix for sh: argument expected, with local CONFIG_DEBUG_OUTPUT enabled and fused in ROM.
    Includes linuxboot#1317, linuxboot#1121, linuxboot#1312, linuxboot#1305, linuxboot#1251 for test on daily driver
tlaurion referenced this pull request in tlaurion/heads Feb 19, 2023
@tlaurion
Merge branch 'dasharo_flashrom_test' into O3-O2-to-Os_coreboot-4.19-f…
367675b 
…ix-sh_argument_expected-yubikey-oem-factory-reset_dasharo-flashrom

Daily driver test fo x230-hotp-maximized on coreboot 4.19, with debug, yubikey test regression for oem-factory-reset, optimized for space (03-O2->Os) and fix for sh: argument expected, with local CONFIG_DEBUG_OUTPUT enabled and fused in ROM.
    Includes osresearch#1317, osresearch#1121, osresearch#1312, osresearch#1305, osresearch#1251 for test on daily driver
@tlaurion
Copy link
Collaborator Author

Using x230-hotp-maximized from CircleCI builds as of now. Nothing to report as of now as regression.

@tlaurion
Copy link
Collaborator Author

So we have:

  • one xx20 tested: x220 (thanks @srgrint !)
  • one xx30 tested: x230 (myself)

@tlaurion
Pass all coreboot 4.13 boards to 4.19
6300dd1 
- Add 4.19 under modules/coreboot
- point all 4.13 boards to 4.19
- adapt x230 FHD/EDP patch under patches/coreboot-4.19/0001-x230-fhd-variant.patch (poked upstream to fix patch under https://review.coreboot.org/c/coreboot/+/28950)
- correct versioning info under .circleci/config/yml
@tlaurion tlaurion force-pushed the coreboot-4.13_coreboot-4.19_version_bump branch from 5589657 to 6300dd1 Compare February 27, 2023 23:08
@tlaurion
Copy link
Collaborator Author

tlaurion commented Feb 27, 2023 •
edited
Loading

Forced pushed after rebase on master.

ROM downloads will be available in ~1 hour under artifacts of each board configs at https://app.circleci.com/pipelines/github/tlaurion/heads/1503/workflows/a137ff59-649a-48f3-8a7f-ad540b4ef9c7 for 30 days as usual.

@srgrint
Copy link
Contributor

srgrint commented Feb 28, 2023 •
edited
Loading

Confirmed that the rebase still works with x220-maximized

Also tested my t430 - again works fine

Also confirmed that t440p-maximized works with master, but bumped to coreboot 4.19

@tlaurion
Copy link
Collaborator Author

tlaurion commented Mar 1, 2023

@srgrint thanks, means a lot

@natterangell
Copy link
Contributor

natterangell commented Mar 27, 2023 •
edited
Loading

Works great on t420-hotp-maximized, including suspend/resume.

It also fixed this minor “bug”, which is now gone 😊
FAA0AD1F-490A-44AB-9D71-C776668C69CD

@tlaurion tlaurion merged commit 3a38ac0 into linuxboot:master Apr 24, 2023
@tlaurion tlaurion mentioned this pull request Apr 25, 2023
Closed
@tlaurion
Copy link
Collaborator Author

Since at least one xx30 (x230+t430) and one xx20 (t420) was tested, it was decided to merge.

We have a testing problem folks (merged but not confirmed working):

Untested boards might move into untested board dir soon. Time to step up!

@tlaurion tlaurion mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlaurion @srgrint @natterangell